Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enabled tests marked with sqlite bug #23384

Merged
1 commit merged into from
Nov 18, 2020
Merged

Enabled tests marked with sqlite bug #23384

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions test/EFCore.Sqlite.FunctionalTests/Query/ManyToManyNoTrackingQuerySqliteTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,5 @@ public override async Task Filtered_include_skip_navigation_order_by_skip_take_t
SqliteStrings.ApplyNotSupported,
(await Assert.ThrowsAsync<InvalidOperationException>(
() => base.Filtered_include_skip_navigation_order_by_skip_take_then_include_skip_navigation_where(async))).Message);

[ConditionalTheory(Skip = "Issue#21541")]
public override Task Left_join_with_skip_navigation(bool async)
=> base.Left_join_with_skip_navigation(async);
}
}
4 changes: 0 additions & 4 deletions test/EFCore.Sqlite.FunctionalTests/Query/ManyToManyQuerySqliteTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,5 @@ public override async Task Filtered_include_skip_navigation_order_by_skip_take_t
SqliteStrings.ApplyNotSupported,
(await Assert.ThrowsAsync<InvalidOperationException>(
() => base.Filtered_include_skip_navigation_order_by_skip_take_then_include_skip_navigation_where(async))).Message);

[ConditionalTheory(Skip = "Issue#21541")]
public override Task Left_join_with_skip_navigation(bool async)
=> Task.CompletedTask;
}
}
4 changes: 0 additions & 4 deletions test/EFCore.Sqlite.FunctionalTests/Query/NorthwindSelectQuerySqliteTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,10 +134,6 @@ public override async Task Select_datetime_TimeOfDay_component(bool async)
FROM ""Orders"" AS ""o""");
}

[ConditionalTheory(Skip = "Issue#21541")]
public override Task Project_single_element_from_collection_with_multiple_OrderBys_Take_and_FirstOrDefault_2(bool async)
=> base.Project_single_element_from_collection_with_multiple_OrderBys_Take_and_FirstOrDefault_2(async);

public override async Task SelectMany_correlated_with_outer_1(bool async)
=> Assert.Equal(
SqliteStrings.ApplyNotSupported,
Expand Down
4 changes: 0 additions & 4 deletions test/EFCore.Sqlite.FunctionalTests/Query/TPTManyToManyNoTrackingQuerySqliteTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,5 @@ public override async Task Filtered_include_skip_navigation_order_by_skip_take_t
SqliteStrings.ApplyNotSupported,
(await Assert.ThrowsAsync<InvalidOperationException>(
() => base.Filtered_include_skip_navigation_order_by_skip_take_then_include_skip_navigation_where(async))).Message);

[ConditionalTheory(Skip = "Issue#21541")]
public override Task Left_join_with_skip_navigation(bool async)
=> base.Left_join_with_skip_navigation(async);
}
}
4 changes: 0 additions & 4 deletions test/EFCore.Sqlite.FunctionalTests/Query/TPTManyToManyQuerySqliteTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,5 @@ public override async Task Filtered_include_skip_navigation_order_by_skip_take_t
SqliteStrings.ApplyNotSupported,
(await Assert.ThrowsAsync<InvalidOperationException>(
() => base.Filtered_include_skip_navigation_order_by_skip_take_then_include_skip_navigation_where(async))).Message);

[ConditionalTheory(Skip = "Issue#21541")]
public override Task Left_join_with_skip_navigation(bool async)
=> base.Left_join_with_skip_navigation(async);
}
}