[5.0.1] Avoid stack overflow in negative many-to-many cases #23455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndriySvyryd
force-pushed
the
Issue23377
branch
from
1b0315d
to
f26e828
Compare
ajcvickers
reviewed
Nov 24, 2020
| t => t.HasOne(a => a.Related).WithMany(b => b.DirectlyRelatedSelfRefs), | ||
| t => t.HasOne(a => a.SelfRef1).WithMany(b => b.SelfRef2)); | ||
|
|
||
| Assert.Equal(CoreStrings.EntityRequiresKey(nameof(SelfRefManyToOne)), |
There was a problem hiding this comment.
Why is EntityRequiresKey thrown in these cases?
There was a problem hiding this comment.
If the join entity is same as one side of skip navigation entities then we don't configure the PK to be composite key of FK properties in join entity.
There was a problem hiding this comment.
If we use the normal rule the PK will include the FKs to the both of the types in many-to-many, and since one of them is the same entity type we are configuring then after setting the PK we will change the FK to target all PK properties and if the FK is changed we'll change the PK to include all of the FK properties and so on.
smitpatel
approved these changes
Nov 24, 2020
|
Approved by Tactics for 5.0.1. |
AndriySvyryd
force-pushed
the
Issue23377
branch
from
f26e828
to
ade87da
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23377
Fixes #23354
Description
Some unsupported models cause
StackOverflowExceptioninstead of a more useful exception.Customer Impact
Using the same property for a self-referencing many-to-many or using the same entity type as the join entity type produces a
StackOverflowException.How found
Multiple customers reported on 5.0.
Test coverage
Added tests for affected scenarios
Regression?
No, many-to-many is a new feature in 5.0
Risk
Low. This only affects many-to-many.