Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Json Columns query work #28171

Merged
merged 1 commit into from
Aug 15, 2022
Merged

Json Columns query work #28171

merged 1 commit into from
Aug 15, 2022

Conversation

maumar
Copy link
Contributor

@maumar maumar commented Jun 7, 2022 •
edited
Loading

  • property/navigation access translation,
  • materialization (entity, collection, with nesting)

@maumar maumar force-pushed the JesusChristThatsJsonBourne branch from 9d451c5 to 8f638d7 Compare June 7, 2022 00:51
@maumar maumar force-pushed the JesusChristThatsJsonBourne branch 2 times, most recently from 24700d9 to 1970a47 Compare June 7, 2022 21:05
@smitpatel
Copy link
Member 

                earlierClientProjectionCount = _clientProjections.Count;

This is where we do process after lifting from single result subquery. Recompute the dedupe map here from this point to end point.

Refers to: src/EFCore.Relational/Query/SqlExpressions/SelectExpression.cs:846 in f2ab2b9. [](commit_id = f2ab2b9, deletion_comment = False)

@smitpatel
Copy link
Member

cc: @AndriySvyryd to review metadata/update pipeline changes.

@maumar maumar force-pushed the JesusChristThatsJsonBourne branch 2 times, most recently from 4d1994e to bd68100 Compare August 15, 2022 22:00
@maumar
Json Columns query work
0577a3a 
- property/navigation access translation,
- materialization (entity, collection, with nesting),
- null semantics,

+ tweaks and fixes to the metadata/update part
@maumar maumar merged commit 0577a3a into main Aug 15, 2022
@maumar maumar deleted the JesusChristThatsJsonBourne branch August 15, 2022 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roji roji roji left review comments

@smitpatel smitpatel smitpatel approved these changes

@AndriySvyryd AndriySvyryd AndriySvyryd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@maumar @AndriySvyryd @smitpatel @ajcvickers @roji