Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unidirectional many-to-many relationships #28371

Merged
merged 2 commits into from
Jul 13, 2022

Conversation

ajcvickers
Copy link
Member

Fixes #3864

@ajcvickers ajcvickers requested a review from a team July 5, 2022 20:27
@ajcvickers
Copy link
Member Author

@dotnet/efteam Creating this as a draft for now since it needs #27493 to be implemented before it can be completed. This is needed in order to execute the query for CollectionEntry.Load, which uses filtered Include, but can't use the MemberInfo-based lambda overload, since there is no CLR navigation property.

@ajcvickers ajcvickers marked this pull request as ready for review July 12, 2022 22:23
@ghost
Copy link

ghost commented Jul 12, 2022

Hello @AndriySvyryd!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost
Copy link

ghost commented Jul 12, 2022

Apologies, while this PR appears ready to be merged, I've been configured to only merge when all checks have explicitly passed. The following integrations have not reported any progress on their checks and are blocking auto-merge:

  1. Azure Pipelines

These integrations are possibly never going to report a check, and unblocking auto-merge likely requires a human being to update my configuration to exempt these integrations from requiring a passing check.

Give feedback on this
From the bot dev team

We've tried to tune the bot such that it posts a comment like this only when auto-merge is blocked for exceptional, non-intuitive reasons. When the bot's auto-merge capability is properly configured, auto-merge should operate as you would intuitively expect and you should not see any spurious comments.

Please reach out to us at fabricbotservices@microsoft.com to provide feedback if you believe you're seeing this comment appear spuriously. Please note that we usually are unable to update your bot configuration on your team's behalf, but we're happy to help you identify your bot admin.

@AndriySvyryd AndriySvyryd changed the base branch from main to release/7.0-preview7 July 13, 2022 01:07
@ghost
Copy link

ghost commented Jul 13, 2022

Apologies, while this PR appears ready to be merged, it looks like release/7.0-preview7 is a protected branch and I have not been granted permission to perform the merge.

@AndriySvyryd AndriySvyryd merged commit 447322c into release/7.0-preview7 Jul 13, 2022
@AndriySvyryd AndriySvyryd deleted the BackBenchers0702 branch July 13, 2022 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support unidirectional many-to-many relationships
2 participants