Metadata #3
Metadata #3
Conversation
|
You mean dev |
|
@davidfowl - RTFM! :-) |
| using JetBrains.Annotations; | ||
| using Microsoft.Data.Core.Utilities; | ||
|
|
||
| public class Entity : MetadataBase |
There was a problem hiding this comment.
Should be EntityType; entities are instances of entity types.
There was a problem hiding this comment.
Not sure this distinction actually matters here:
- This type is in Metadata.
- Would we have another type called Entity representing an instance?
There was a problem hiding this comment.
My initial thought was also EntityType, but I'm willing to try without the type for now and see how it ends up feeling.
There was a problem hiding this comment.
One of my college professors always insisted on using the proper terminologies, so anything but entity type just feels wrong to me. I also got a little confused in the Model class at first thinking it was the change tracker (since it was adding entities and not entity types).
There was a problem hiding this comment.
But the current fluent api also doesn't feel wrong since I read mb.Entity<Person>() as "Entities of type Person..."
There was a problem hiding this comment.
@bricelam Are you arguing that it is not "mathematically correct"? :-P
There was a problem hiding this comment.
Yes, but I was very careful to avoid that phrase. ;)
|
I'm generally against the internal keyword but some of those extension methods should be internal. |
This is the API surface required to build the version of Music Store checked in. No implementation as yet, and some things (like Database.Create) will likely change.
- DataStore abstraction for stores - EntityConfiguration, a configuration model and EntityContext factory. - EntityServices, a static default IServiceProvider factory, matching the current K standard pattern - ConsoleLoggerFactory, an impl. of ILoggerFactory
|
Merged. |
This is a dummy PR for the EF team to review early metadata and basic infra work. NB: This will not be pushed to master :-)