Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix NativeAOT warnings in Microsoft.Data.Sqlite #31328

Merged
merged 1 commit into from
Jul 21, 2023
Merged

Fix NativeAOT warnings in Microsoft.Data.Sqlite #31328

merged 1 commit into from
Jul 21, 2023

Conversation

AndriySvyryd
Copy link
Member

Part of #29761

@AndriySvyryd AndriySvyryd requested a review from a team as a code owner July 21, 2023 01:58
bricelam
bricelam approved these changes Jul 21, 2023
View reviewed changes
Copy link
Contributor

@bricelam bricelam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let's discuss the breaking change as a team.

src/Microsoft.Data.Sqlite.Core/Microsoft.Data.Sqlite.Core.csproj Outdated Show resolved Hide resolved
@AndriySvyryd AndriySvyryd merged commit 84b734d into main Jul 21, 2023
7 checks passed
@AndriySvyryd AndriySvyryd deleted the NativeAOT branch July 21, 2023 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbomer sbomer sbomer left review comments

@bricelam bricelam bricelam approved these changes

@roji roji roji left review comments

@eerhardt eerhardt eerhardt left review comments

@vitek-karas vitek-karas vitek-karas left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@AndriySvyryd @sbomer @bricelam @roji @eerhardt @vitek-karas