Throw in model validation for unqualified types like "nvarchar" and "varbinary" #4500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Exception message looks good |
|
|
…varbinary" If the app really wants a data type like this with a length of one, then it should use, for example, "nvarchar(1)". This stops apps from putting, for example, nvarchar and then setting a max length of 16 in the API and expecting this to be transformed into the type nvarchar(16). Also, some cleanup in the type mapper and model validator classes.
ajcvickers
force-pushed
the
OneToGone0204
branch
from
006502f
to
219ce0f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the app really wants a data type like this with a length of one, then it should use, for example, "nvarchar(1)". This stops apps from putting, for example, nvarchar and then setting a max length of 16 in the API and expecting this to be transformed into the type nvarchar(16).
Also, some cleanup in the type mapper and model validator classes.