Support mapping to fields #6269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajcvickers
force-pushed
the
HasField0728
branch
2 times, most recently
from
99ece93
to
e77cdec
Compare
|
@ajcvickers Any guidance on specific areas of this to review? |
|
@anpete Probably the biggest change is the way fields are found and set in metadata when using the convention or the API. Then possibly the rules for choosing a field or a property based on mode. |
|
|
| [NotNull] this IPropertyBase propertyBase, | ||
| bool forConstruction, | ||
| bool forSet) | ||
| { |
There was a problem hiding this comment.
Consider using an out parameter or return a Tuple
|
|
ajcvickers
force-pushed
the
HasField0728
branch
from
e77cdec
to
b0c503d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues #4357, #4855
This change adds fluent and lower-level APIs to set backing fields or properties with no fields as well as conventions for using the fields and a mechanism to provide control over when the property is used and when the field is used.
Also see #6266, #6267, and #6268.
/cc @rowanmiller for API and docs