-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump test projects up to .NET 4.5.2 #7607
Conversation
dougbu
commented
Feb 14, 2017
•
edited by bricelam
Loading
edited by bricelam
- .NET 4.5.1 test runs fail with "EXEC : warning : No test is available" aspnet/Testing#248
- xUnit no longer supports .NET 4.5.1
@@ -3,6 +3,7 @@ | |||
<PropertyGroup> | |||
<DefineConstants>$(DefineConstants);CSPROJ</DefineConstants> | |||
<DefineConstants Condition=" '$(TargetFrameworkMoniker)' == '.NETFramework,Version=v4.5.1' ">$(DefineConstants);NET451</DefineConstants> | |||
<DefineConstants Condition=" '$(TargetFrameworkMoniker)' == '.NETFramework,Version=v4.5.2' ">$(DefineConstants);NET452</DefineConstants> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure whether this will be necessary after project.json files are removed. But, for now best to cover both cases…
@@ -33,7 +33,7 @@ | |||
"Microsoft.CSharp": "4.4.0-*" | |||
} | |||
}, | |||
"net451": { | |||
"net452": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@natemcmaster bit of a concern that I needed to change this project. Without the change, CI runs failed with missing symbols in test projects because the dependencies listed below weren't brought in. Is that a bug in transitive references?
With this change, I will also need to change other src
projects that reference this one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be. We should try this on csproj and see if it works better there (#7542)
- aspnet/Testing#248 - xUnit no longer supports .NET 4.5.1
- does Microsoft.EntityFrameworkCore.Specification.Tests package ship to customers?
This reverts commit beca39d.
This reverts commit c3a25a9.
- require System.Xml framework assembly and that's not available xplat - will have to wait for migration from project.json
beca39d
to
6d6c396
Compare
@bricelam the CI failures on Windows seem to be fairly random -- SQL timeouts. But the failures on OSX and Linux are real and potentially a blocker. Microsoft.EntityFrameworkCore.InMemory.FunctionalTests and two other projects fail to compile because these platforms have no System.Xml.dll reference assemblies. I've tried a couple of things and have not improved matters. Options:
Thoughts? |
I opt for number one. I'll update that PR, and investigate any failures. |
Thanks @bricelam 👍 |