-
Notifications
You must be signed in to change notification settings - Fork 784
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
AsyncLocal diagnostics, clean slate (#16779)
* fix some inconsistencies * we don't intend to dispose this ever * removed * multiple loggers * fix RegisterAndImportReferencedAssemblies * fix deadlock in fsi * fix some BuildGraphTests * restore asyncmemoize * fix missing logger in test * format * fix transparent compiler nre * cleanup * default value * add some comments * foramt and notes to make it green if it's green * wrap any parallel computations that potentially push diagnostics * try to fix buildgraphtests * try to eradicate deadlocks in tests * fix buildgraph test * disable for a moment * flatten exceptions * reshuffle * prevent graphnode deadlock * yield * diff * add some comments * add AsyncLocal test * more testing * not needed after all? * test * format * revert * try RunContinuationsAsynchronously * try to deal with deadlock another way * nope * revert * format * restore release notes * add test for ListParallel * speed up test * improve test * simpler MultipleDiagnosticsLoggers * rename and speedup test * parallel logging perf * remove SwitchToThreadPool * sequential * Revert "sequential" This reverts commit 8c77c0c. * revert spurious change * fix comments * test MultipleDiagnosticsLoggers * add comment and clean up --------- Co-authored-by: Petr <psfinaki@users.noreply.github.com>
- Loading branch information
Showing
26 changed files
with
696 additions
and
740 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,7 @@ | ||
### Fixed | ||
|
||
* Make tooltips work in file with no solution. ([PR #17054](https://github.com/dotnet/fsharp/pull/17054)) | ||
|
||
### Changed | ||
|
||
* Use AsyncLocal diagnostics context. ([PR #16779])(https://github.com/dotnet/fsharp/pull/16779)) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.