Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SO in non-recursive bindings checks #17415

Closed
vzarytovskii opened this issue Jul 16, 2024 · 0 comments · Fixed by #17654
Closed

SO in non-recursive bindings checks #17415

vzarytovskii opened this issue Jul 16, 2024 · 0 comments · Fixed by #17654
Assignees
@T-Gro
Labels
Area-Compiler-Checking Type checking, attributes and all aspects of logic checking Bug Impact-High (Internal MS Team use only) Describes an issue with extreme impact on existing code.
Milestone
September-2024

Comments

@vzarytovskii
Copy link
Member

vzarytovskii commented Jul 16, 2024 •
edited
Loading

Consider having file with module and a bunch of nested modules and bindings in all of them, it will fail with SO. Declaring module as rec will fix it. It is some corner case of #16869

image

Issue is in calling between TcModuleOrNamespaceElementNonMutRec and TcModuleOrNamespaceElements, calls are not tail recursive (due to using builder). It will also likely only occur in full CLR, coreclr's JIT is much better at dealing with tail prefixes.
@github-actions github-actions bot added this to the Backlog milestone Jul 16, 2024
@T-Gro T-Gro added the Area-Compiler-Checking Type checking, attributes and all aspects of logic checking label Jul 19, 2024
@vzarytovskii vzarytovskii modified the milestones: Backlog, August-2024 Jul 31, 2024
@vzarytovskii vzarytovskii added the Impact-High (Internal MS Team use only) Describes an issue with extreme impact on existing code. label Jul 31, 2024
@ArtemyB ArtemyB mentioned this issue Aug 14, 2024
Closed
ArtemyB added a commit to ArtemyB/Feliz.MaterialUI that referenced this issue Aug 14, 2024
@ArtemyB
fix: resolve issue with compilation by Fable >= v4.8.0 related to the…
d0d1e03 
… FCS bug

Resolves (as a workaround) the following Fable issue: fable-compiler/Fable#3752
The solution is to make all the big modules (with a lot of bindings) recursive (i.e., mark them with `rec` modifier). The workaround is taken from the originating F# issue: dotnet/fsharp#17415

Update Fable .NET tool version to `4.19.3`.

Bump package versions:
- Feliz.MaterialUI to v5.11.0-beta.4
- Feliz.MaterialUI.Icons to v5.10.0-beta.3
- Feliz.MuiX.DatePickers to v5.0.0-beta.3
- Feliz.MuiX.DatePickersPro to v5.0.0-beta.3

closes #7
@ArtemyB ArtemyB mentioned this issue Aug 14, 2024
Open
@T-Gro T-Gro modified the milestones: August-2024, September-2024 Sep 5, 2024
@T-Gro T-Gro linked a pull request Sep 5, 2024 that will close this issue
Address StackOverflowExceptions in typechecking #17654
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@T-Gro T-Gro

Labels
Area-Compiler-Checking Type checking, attributes and all aspects of logic checking Bug Impact-High (Internal MS Team use only) Describes an issue with extreme impact on existing code.
Projects
F# Compiler and Tooling
Archived in project
Milestone
September-2024
Development

Successfully merging a pull request may close this issue.

Address StackOverflowExceptions in typechecking dotnet/fsharp
2 participants
@vzarytovskii @T-Gro