Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VS: option pages erroring. #17602

Closed
majocha opened this issue Aug 24, 2024 · 10 comments
Closed

VS: option pages erroring. #17602

majocha opened this issue Aug 24, 2024 · 10 comments
Labels
Area-VS VS support for F# not covered elsewhere Bug Tracking-External
Milestone

Comments

@majocha
Copy link
Contributor

majocha commented Aug 24, 2024

This is not the released version, but a vsix built from latest main installed into latest VS 17.12.0 Preview 1.0.

image

The first commit that breaks this for me is:

bc40f6a (#17537)

ETA:
External WPF bug: dotnet/wpf#9582

@github-actions github-actions bot added this to the Backlog milestone Aug 24, 2024
@majocha
Copy link
Contributor Author

majocha commented Aug 24, 2024

image
Huh?

@vzarytovskii
Copy link
Member

Hm, not the first issue with the options - #17015

@majocha
Copy link
Contributor Author

majocha commented Aug 24, 2024

OK it still worked before #17569. Shouldn't take long to bisect.

@vzarytovskii
Copy link
Member

Wondering if translations are out of date

@majocha
Copy link
Contributor Author

majocha commented Aug 24, 2024

I think all the strings we use in XAML are bound with x:Static so anything missing would fail at build.

I suspect some dependencies changed and are somehow conflicting with net472 era WPF in a way that surfaces only at runtime. Roslyn uses quite a lot of XAML in the C# extension, I wonder if they're seeing this problem.

I tried to identify the exact change when this shows up.
The last commit this still works is 6cd4d59,
the next one: bc40f6a (#17537) it's broken.

@majocha
Copy link
Contributor Author

majocha commented Aug 25, 2024

So, the only change is the update to net9 preview 7.
This looks very much like this dotnet/wpf#9620, but why on earth would it affect us if we're targeting net472🤔?

@majocha
Copy link
Contributor Author

majocha commented Aug 25, 2024

OK, this is very likely external and related to net 9 preview 7 changes.

I created a simple WPF app targeting net472:
image

It works fine when built and run from stable VS (17.11.1)

but add a global.json with

  "sdk": {
    "version": "9.0.100-preview.7.24407.12"
  }

and it breaks the same way as our vsix:
image

@vzarytovskii
Copy link
Member

Thanks for investigating, hopefully it is fixed with rc1.

@majocha
Copy link
Contributor Author

majocha commented Aug 25, 2024

Yes, quite a relief nothing's broken on our side 😅.

@abonie abonie added Tracking-External Area-VS VS support for F# not covered elsewhere and removed Needs-Triage labels Aug 26, 2024
@abonie abonie modified the milestones: Backlog, August-2024 Aug 26, 2024
@majocha
Copy link
Contributor Author

majocha commented Sep 13, 2024

Fixed with 9rc1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-VS VS support for F# not covered elsewhere Bug Tracking-External
Projects
Archived in project
Development

No branches or pull requests

3 participants