Fix MEF issues with options #17015
Merged
Fix MEF issues with options #17015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems something changed about MEF import w.r.t. private members.
vzarytovskii
added
the
NO_RELEASE_NOTES
|
|
I can confirm this fixes it. Nice! |
|
Well, that confuses me even more. It's either default MEF behaviour has changed, or we use realsig in the VSIX. |
T-Gro
approved these changes
Apr 10, 2024
|
Tested a few times. Settings window was crashing for me. |
|
I remember MEF... |
KevinRansom
requested changes
Apr 10, 2024
|
Might be mix of realsig + optimizer, since it's Might be, due to new codegen, optimized away in release build. |
|
/backport to release/dev17.10 |
|
Started backporting to release/dev17.10: https://github.com/dotnet/fsharp/actions/runs/8645556492 |
This was referenced Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16965
It seems something changed about MEF import w.r.t. private members. @KevinRansom are we building VSIX with real signatures now by any chance?
Will appreciate confirmation whether it fixes the issue or not.