Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LSP design proposal #16493

Merged
merged 9 commits into from
May 6, 2024
Merged

LSP design proposal #16493

merged 9 commits into from
May 6, 2024

Conversation

0101
Copy link
Contributor

@0101 0101 commented Jan 4, 2024

This is a design document for F# LSP. It's not exhaustive and definitely not final, but should be good to kick start discussions about the topic and base some initial work/investigation off of.

Please check it out and comment/suggest changes and point out missing parts.

To view rendered markdown go to Files changed, ... -> View file

@0101 0101 requested a review from a team as a code owner January 4, 2024 14:51
Copy link
Contributor

github-actions bot commented Jan 4, 2024

✅ No release notes required

@0101 0101 linked an issue Jan 4, 2024 that may be closed by this pull request
Copy link
Member

@baronfel baronfel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some very early thoughts. We should probably have a chat between the F# team and the FSAC maintainers about how things will work together.

docs/lsp.md Show resolved Hide resolved
docs/lsp.md Show resolved Hide resolved
docs/lsp.md Outdated Show resolved Hide resolved
docs/lsp.md Show resolved Hide resolved
docs/lsp.md Show resolved Hide resolved
docs/lsp.md Outdated Show resolved Hide resolved
docs/lsp.md Outdated Show resolved Hide resolved
@nojaf
Copy link
Contributor

nojaf commented Jan 4, 2024

Would this move FCS to something higher than netstandard2.0?

@auduchinok
Copy link
Member

Would this move FCS to something higher than netstandard2.0?

We still have to target net472/netstandard2.0 in the Rider plugin for now, unfortunately. 😞

@vzarytovskii
Copy link
Member

Would this move FCS to something higher than netstandard2.0?

Not at this point. Once we are fully out of process, we can think about it.

@vzarytovskii
Copy link
Member

Would this move FCS to something higher than netstandard2.0?

Library on top of lsp will be net9 likely.

@vzarytovskii
Copy link
Member

Would this move FCS to something higher than netstandard2.0?

To add, given that long-term we want to:

  • Host oop in VS.
  • Ditch full framework compiler (as executable, not target of course), leave only coreclr one.

Once done, we can probably move to latest (-ish) target for FCS, so we can utilise things like Spans, and vectorized collection operations, etc.

docs/lsp.md Outdated Show resolved Hide resolved
docs/lsp.md Outdated Show resolved Hide resolved
docs/lsp.md Outdated Show resolved Hide resolved
docs/lsp.md Outdated Show resolved Hide resolved
docs/lsp.md Outdated Show resolved Hide resolved
@nojaf
Copy link
Contributor

nojaf commented Jan 8, 2024

What are the initial thoughts on the release process for these LSP deliverables?
What would the cycle look like?

@vzarytovskii
Copy link
Member

vzarytovskii commented Jan 8, 2024

What are the initial thoughts on the release process for these LSP deliverables?

What would the cycle look like?

That is to be decided, didn't really think about it yet.

0101 and others added 6 commits January 8, 2024 11:26
Co-authored-by: Vlad Zarytovskii <vzaritovsky@hotmail.com>
Co-authored-by: Vlad Zarytovskii <vzaritovsky@hotmail.com>
docs/lsp.md Show resolved Hide resolved
@abonie abonie enabled auto-merge (squash) May 6, 2024 17:32
@abonie abonie merged commit 325f60a into dotnet:main May 6, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LSP: Design, publish and discuss LSP layer architecture
8 participants