Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Computed collections: simple count check #16947

Merged
merged 3 commits into from
Apr 4, 2024
Merged

Computed collections: simple count check #16947

merged 3 commits into from
Apr 4, 2024

Conversation

brianrourkeboll
Copy link
Contributor

@brianrourkeboll brianrourkeboll commented Mar 25, 2024 •
edited
Loading

Description

Followup to #16650 and #16832.

  • Use count = 0 instead of count < 1. The count < 1 check was a vestige of an older approach for computing the count and isn't needed.

Checklist

  • Test cases added.
  • Release notes entry updated.

@brianrourkeboll
Use count = 0 instead of count < 1
b926f10 
* The count < 1 check was a vestige of an older approach for computing
  the count that could result in a negative count.
@brianrourkeboll
Update baselines
77cff30
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 25, 2024 •
edited
Loading

❗ Release notes required

✅ Found changes and release notes in following paths:

Change path Release notes path Description
src/Compiler docs/release-notes/.FSharp.Compiler.Service/8.0.300.md

@brianrourkeboll brianrourkeboll marked this pull request as ready for review March 26, 2024 00:30
@brianrourkeboll brianrourkeboll requested a review from a team as a code owner March 26, 2024 00:30
@psfinaki
Copy link
Member

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@abonie abonie merged commit 71442c8 into dotnet:main Apr 4, 2024
32 checks passed
@brianrourkeboll brianrourkeboll deleted the computed-collections-simple-count-check branch April 5, 2024 14:59
This was referenced Apr 9, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psfinaki psfinaki psfinaki approved these changes

@abonie abonie abonie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
F# Compiler and Tooling
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brianrourkeboll @psfinaki @abonie