Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes #17541 - Equals visibility for DU's #17548

Merged
merged 2 commits into from
Aug 19, 2024
Merged

fixes #17541 - Equals visibility for DU's #17548

merged 2 commits into from
Aug 19, 2024

Conversation

KevinRansom
Copy link
Member

@KevinRansom KevinRansom commented Aug 15, 2024 •
edited
Loading

This PR:

@KevinRansom KevinRansom requested a review from a team as a code owner August 15, 2024 21:32
@KevinRansom KevinRansom marked this pull request as draft August 15, 2024 21:32
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 15, 2024 •
edited
Loading

❗ Release notes required

✅ Found changes and release notes in following paths:

Change path Release notes path Description
src/Compiler docs/release-notes/.FSharp.Compiler.Service/9.0.100.md

@KevinRansom KevinRansom changed the title Wip - fixes Equals visibility for DU's Wip - fixes #17541 - Equals visibility for DU's Aug 16, 2024
@KevinRansom KevinRansom added this to the August-2024 milestone Aug 16, 2024
@KevinRansom KevinRansom marked this pull request as ready for review August 16, 2024 18:35
@KevinRansom KevinRansom changed the title Wip - fixes #17541 - Equals visibility for DU's fixes #17541 - Equals visibility for DU's Aug 19, 2024
@T-Gro T-Gro linked an issue Aug 19, 2024 that may be closed by this pull request
MethodAccessException on equality comparison of a type private to module #17541
Closed
@vzarytovskii vzarytovskii merged commit d0d6b4e into dotnet:main Aug 19, 2024
30 checks passed
This was referenced Aug 28, 2024
Closed
Open
@dotnet-bot dotnet-bot mentioned this pull request Sep 14, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vzarytovskii vzarytovskii vzarytovskii approved these changes

@T-Gro T-Gro T-Gro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
F# Compiler and Tooling
Archived in project
Milestone
August-2024
Development

Successfully merging this pull request may close these issues.

MethodAccessException on equality comparison of a type private to module
3 participants
@KevinRansom @vzarytovskii @T-Gro