Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detect open type use correctly for enums #17628

Merged
merged 2 commits into from
Aug 30, 2024
Merged

Detect open type use correctly for enums #17628

merged 2 commits into from
Aug 30, 2024

Conversation

brianrourkeboll
Copy link
Contributor

@brianrourkeboll brianrourkeboll commented Aug 28, 2024 •
edited
Loading

Description

Fixes #17619.

  • Consider open type used when the type is an enum and any of the enum cases is used unqualified.

Checklist

  • Test cases added.
  • Release notes entry updated.

@brianrourkeboll
Detect open type use correctly for enums
930cf98 
* Consider `open type` used when the type is an enum and any of
  the enum cases is used unqualified.
@brianrourkeboll
Update release notes
6461ad8
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 28, 2024 •
edited
Loading

❗ Release notes required

✅ Found changes and release notes in following paths:

Change path Release notes path Description
src/Compiler docs/release-notes/.FSharp.Compiler.Service/9.0.100.md

@brianrourkeboll brianrourkeboll marked this pull request as ready for review August 28, 2024 19:05
@brianrourkeboll brianrourkeboll requested a review from a team as a code owner August 28, 2024 19:05
@brianrourkeboll brianrourkeboll marked this pull request as draft August 28, 2024 19:13
@brianrourkeboll brianrourkeboll marked this pull request as ready for review August 28, 2024 19:22
psfinaki
psfinaki approved these changes Aug 29, 2024
View reviewed changes
Copy link
Member

@psfinaki psfinaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for a quick fix, that was annoying indeed.

vzarytovskii
vzarytovskii approved these changes Aug 30, 2024
View reviewed changes
Copy link
Member

@vzarytovskii vzarytovskii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@vzarytovskii vzarytovskii merged commit 1f1ee49 into dotnet:main Aug 30, 2024
30 checks passed
@brianrourkeboll brianrourkeboll deleted the open-type-enums branch August 30, 2024 13:41
This was referenced Sep 11, 2024
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vzarytovskii vzarytovskii vzarytovskii approved these changes

@psfinaki psfinaki psfinaki approved these changes

@edgarfgp edgarfgp edgarfgp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
F# Compiler and Tooling
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

open type T when T is an enum is treated as unused even when it's used
4 participants
@brianrourkeboll @vzarytovskii @psfinaki @edgarfgp