Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wrong [<TailCall>] warning with unit-returning match expression #17637

Merged
merged 4 commits into from
Aug 30, 2024
Merged

Fix wrong [<TailCall>] warning with unit-returning match expression #17637

merged 4 commits into from
Aug 30, 2024

Conversation

dawedawe
Copy link
Contributor

Description

Fixes #17604

I think we missed the handling for rec functions that are just unit-returning match expressions.

Checklist

  • Test cases added
  • Performance benchmarks added in case of performance changes
  • Release notes entry updated

@dawedawe dawedawe requested a review from a team as a code owner August 30, 2024 08:57
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 30, 2024 •
edited
Loading

❗ Release notes required

✅ Found changes and release notes in following paths:

Change path Release notes path Description
src/Compiler docs/release-notes/.FSharp.Compiler.Service/9.0.100.md

psfinaki
psfinaki approved these changes Aug 30, 2024
View reviewed changes
Copy link
Member

@psfinaki psfinaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for a quick fix Dawe!

vzarytovskii
vzarytovskii approved these changes Aug 30, 2024
View reviewed changes
Copy link
Member

@vzarytovskii vzarytovskii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks

@vzarytovskii vzarytovskii enabled auto-merge (squash) August 30, 2024 11:11
@vzarytovskii vzarytovskii merged commit 138593b into dotnet:main Aug 30, 2024
30 checks passed
@dawedawe dawedawe deleted the fix_17604 branch August 30, 2024 12:56
This was referenced Sep 11, 2024
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vzarytovskii vzarytovskii vzarytovskii approved these changes

@psfinaki psfinaki psfinaki approved these changes

@edgarfgp edgarfgp edgarfgp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
F# Compiler and Tooling
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TailCall attribute incorrectly warning
4 participants
@dawedawe @vzarytovskii @psfinaki @edgarfgp