Use ProductMonikerRid instead of CoreSetupRid for SDK RID.
#141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit changes `NETCoreSdkRuntimeIdentifier` to be based off of `ProductMonikerRid` instead of `CoreSetupRid`. `CoreSetupRid` is set to the host RID for the build, by default. For most architectures, this was fine. However, for ARM/ARM64 builds, we cross-build, so `CoreSetupRid` is actually x64 and not ARM/ARM64. As a result, the default apphost being used isn't built for ARM so `dotnet run` fails with an exec format error when trying to exec the apphost. Instead, we should be using the RID of the product being built rather than the host RID. Fixes dotnet/cli#10291.
nguerrera
approved these changes
Nov 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes
NETCoreSdkRuntimeIdentifierto be based off ofProductMonikerRidinstead ofCoreSetupRid.CoreSetupRidis set to the host RID for the build, by default. For mostarchitectures, this was fine. However, for ARM/ARM64 builds, we cross-build,
so
CoreSetupRidis actually x64 and not ARM/ARM64.As a result, the default apphost being used isn't built for ARM so
dotnet runfails with an exec format error when trying to exec the apphost.
Instead, we should be using the RID of the product being built rather than the
host RID.
Fixes dotnet/cli#10291.