Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebootstrap with new SB artifacts and SDK #18278

Merged
merged 2 commits into from
Jan 17, 2024

Conversation

ellahathaway
Copy link
Member

Re-bootstrapping the VMR with new source-build artifacts and SDK.

Fixes dotnet/source-build#3974
Unblocks #18213

@ellahathaway ellahathaway requested a review from a team as a code owner January 17, 2024 18:29
@mthalman
Copy link
Member

Yeah, the build failure makes sense. This is now doing the equivalent of what stage 2 was before. So it's running into this: dotnet/source-build#3968. We need the Arcade fix to roll in and then run another build with that fix to get new artifacts/sdk.

@ellahathaway
Copy link
Member Author

We need the Arcade fix to roll in and then run another build with that fix to get new artifacts/sdk.

Will the fix from dotnet/arcade#14377 roll in independent of #18213 (comment)?

@mthalman
Copy link
Member

We need the Arcade fix to roll in and then run another build with that fix to get new artifacts/sdk.

Will the fix from dotnet/arcade#14377 roll in independent of #18213 (comment)?

No, the fix will need to come into installer via dependency flow from arcade.

@ellahathaway
Copy link
Member Author

I'm a bit confused. I understand that we need the changes from dotnet/arcade#14377 to flow into installer in order to unblock this PR, but if those changes are flowing in as part of #18213 and #18213 is simultaneously blocked by this PR, what is the order of things?

Would we merge #18213 with the changes from dotnet/arcade#14377 despite it being blocked by needing to rebootstrap?

@mthalman
Copy link
Member

Oh, I didn't realize it was blocked by this PR. In that case, we'll want to update this PR to contain a patch for the fix in dotnet/arcade#14377.

@ellahathaway ellahathaway merged commit 84a8998 into dotnet:main Jan 17, 2024
16 checks passed
@ellahathaway ellahathaway deleted the rebootstrap branch January 17, 2024 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Alpine319_Offline_PreviousSourceBuiltSdk_x64 fails due to no .NET SDK
2 participants