Update to .NET 7-era packages #8347
Conversation
To match what we ship, 7.0.0.0 now.
Conflicts: eng/Versions.props eng/dependabot/Packages.props
rainersigwald
force-pushed
the
exp/net7-packages
branch
from
c6bdc35
to
4d145c1
Compare
rainersigwald
force-pushed
the
exp/net7-packages
branch
from
4d145c1
to
de221b8
Compare
rainersigwald
added
the
merge-when-branch-open
| <SystemResourcesExtensionsPackageVersion>6.0.0</SystemResourcesExtensionsPackageVersion> | ||
| <SystemSecurityPermissionsVersion>6.0.0</SystemSecurityPermissionsVersion> | ||
| <SystemReflectionMetadataLoadContextVersion>7.0.0</SystemReflectionMetadataLoadContextVersion> | ||
| <SystemReflectionMetadataVersion>7.0.0</SystemReflectionMetadataVersion> |
There was a problem hiding this comment.
@ViktorHofer, @jkoritzinsky, @trylek re: dotnet/arcade#10516
Should we also update this in host model? https://github.com/dotnet/runtime/blob/1f8d401995fe904c69d28a05bef7948d6affe2c2/src/installer/managed/Microsoft.NET.HostModel/Microsoft.NET.HostModel.csproj#L22-L23 @mmitche has updated it in the SDK repo.
This came up yesterday in another discussion dotnet/runtime#85038 (comment). I think we can unify SRM version to 7.0 across the runtime repo (provided Tomas' ILSpy concern is addressed).
There was a problem hiding this comment.
Could we re-target HostModel to net7.0/net8.0? That would solve the PackageReference issue and would remove the prebuild on S.T.J and S.R.M.
EDIT:
Looks like we can't: https://github.com/dotnet/sdk/blob/8286b1927bd5970797a0eb29877464a12cb79c55/src/Tasks/Microsoft.NET.Build.Tasks/Microsoft.NET.Build.Tasks.csproj#L65
There was a problem hiding this comment.
Yeah Microsoft.NET.HostModel is used by the sdk to implement the tasks that manipulate the apphosts. The dependency requirements for that package are that the dependencies are compatible with being loaded by an MSBuild task in dotnet/sdk build/publish scenarios. We can make any changes that are compatible with that rule (including package upgrades/downgrades, etc).
Update references to packages published from the
dotnet/runtimerepo. This must be done in coordination with the VS repo, which is pending at (Microsoft-internal link) https://dev.azure.com/devdiv/DevDiv/_git/VS/pullrequest/435695.Test insertion from the experimental branch that showed passing VS perf tests (internal again): https://dev.azure.com/devdiv/DevDiv/_git/VS/pullrequest/446441.