Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move release build leg to dnceng pool #8789

Merged
merged 2 commits into from
May 23, 2023
Merged

Move release build leg to dnceng pool #8789

merged 2 commits into from
May 23, 2023

Conversation

rainersigwald
Copy link
Member

Move (only) the Windows Full Release (no bootstrap) leg to the windows.vs2022preview.amd64.open pool, which has Visual Studio 17.6 on it already.

This will unblock #8674 by avoiding dotnet/sdk#32691; the MSBuild.exe.config binding redirects in the 17.6 VS will keep the current versions working for the moment.

Internal test run, since it requires splitting definitions for internal vs external: https://dev.azure.com/devdiv/DevDiv/_build/results?buildId=7804696&view=logs&j=1522e9b9-b859-5e5f-ec86-a68fc9508baf&t=a8d37b2d-1a39-51d6-c11e-8665c8c9811e

@rainersigwald
Copy link
Member Author

Hmm. Failure was #8750, but happened twice in a row in testing so may be more prevalent on this environment. If it happens again, let's disable the test until a fixed version is available.

@Forgind
Copy link
Member

Forgind commented May 22, 2023

@rainersigwald, it seems to have failed again, so I added a Skip for it and pointed to 8750.

rainersigwald and others added 2 commits May 23, 2023 11:05
Move (only) the `Windows Full Release (no bootstrap)` leg to the
`windows.vs2022preview.amd64.open` pool, which has Visual Studio 17.6 on
it already.

This will unblock #8674 by avoiding
dotnet/sdk#32691; the `MSBuild.exe.config`
binding redirects in the 17.6 VS will keep the current versions working
for the moment.
@rainersigwald rainersigwald merged commit 71bc6e0 into main May 23, 2023
@rainersigwald rainersigwald deleted the switch-build-pool branch May 23, 2023 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants