Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare scenarios before sending to Helix #2641

Merged
merged 1 commit into from
Oct 19, 2022
Merged

Prepare scenarios before sending to Helix #2641

merged 1 commit into from
Oct 19, 2022

Conversation

cincuranet
Copy link
Contributor

@cincuranet cincuranet commented Oct 10, 2022 •
edited
Loading

Closes #2416.

This was referenced Oct 11, 2022
Closed
Closed
Closed
@cincuranet
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Pull request contains merge conflicts.

@cincuranet cincuranet marked this pull request as ready for review October 18, 2022 12:23
LoopedBard3
LoopedBard3 approved these changes Oct 18, 2022
View reviewed changes
Copy link
Member

@LoopedBard3 LoopedBard3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really good! I am assuming the next steps are to start using the imported targets in the other scenarios, like blazor and sdk? I can't wait to see the improvements and flexibility this adds to the pipeline.

@cincuranet cincuranet merged commit 9247934 into dotnet:main Oct 19, 2022
@cincuranet cincuranet deleted the prepare-before-helix branch October 19, 2022 08:29
@LoopedBard3 LoopedBard3 mentioned this pull request Jan 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LoopedBard3 LoopedBard3 LoopedBard3 approved these changes

@DrewScoggins DrewScoggins Awaiting requested review from DrewScoggins

@caaavik-msft caaavik-msft Awaiting requested review from caaavik-msft

@sblom sblom Awaiting requested review from sblom

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build vs measure: build creates completely self-contained packages
2 participants
@cincuranet @LoopedBard3