Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove CA2363; not sure if we'd run into it #3953

Merged
merged 1 commit into from
Aug 5, 2020
Merged

Remove CA2363; not sure if we'd run into it #3953

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/NetAnalyzers/Core/AnalyzerReleases.Unshipped.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,4 +10,3 @@ CA2355 | Security | Disabled | DataSetDataTableInSerializableObjectGraphAnalyzer
CA2356 | Security | Disabled | DataSetDataTableInWebSerializableObjectGraphAnalyzer, [Documentation](https://docs.microsoft.com/visualstudio/code-quality/ca2356)
CA2361 | Security | Disabled | DoNotUseDataSetReadXml, [Documentation](https://docs.microsoft.com/visualstudio/code-quality/ca2361)
CA2362 | Security | Disabled | DataSetDataTableInSerializableTypeAnalyzer, [Documentation](https://docs.microsoft.com/visualstudio/code-quality/ca2362)
CA2363 | Security | Disabled | DataSetDataTableInSerializableTypeAnalyzer, [Documentation](https://docs.microsoft.com/visualstudio/code-quality/ca2363)
12 changes: 0 additions & 12 deletions src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/MicrosoftNetCoreAnalyzersResources.resx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1248,12 +1248,6 @@
<data name="DataSetDataTableInRceDeserializableObjectGraphTitle" xml:space="preserve">
<value>Unsafe DataSet or DataTable in deserialized object graph can be vulnerable to remote code execution attacks</value>
</data>
<data name="DataSetDataTableInAutogeneratedSerializableTypeMessage" xml:space="preserve">
<value>When deserializing untrusted input, deserializing a {0} object is insecure. '{1}' either is or derives from {0}. Ensure that the autogenerated type is never deserialized with untrusted data.</value>
</data>
<data name="DataSetDataTableInAutogeneratedSerializableTypeTitle" xml:space="preserve">
<value>Unsafe DataSet or DataTable in autogenerated serializable type</value>
</data>
<data name="DataSetDataTableInRceAutogeneratedSerializableTypeMessage" xml:space="preserve">
<value>When deserializing untrusted input with an IFormatter-based serializer, deserializing a {0} object is insecure. '{1}' either is or derives from {0}. Ensure that the autogenerated type is never deserialized with untrusted data.</value>
</data>
Expand All @@ -1272,10 +1266,4 @@
<data name="DataSetReadXmlAutogeneratedTitle" xml:space="preserve">
<value>Ensure autogenerated class containing DataSet.ReadXml() is not used with untrusted data</value>
</data>
<data name="DataTableReadXmlAutogeneratedMessage" xml:space="preserve">
<value>The method '{0}' is insecure when deserializing untrusted data. Make sure that autogenerated class containing the '{0}' call is not deserialized with untrusted data.</value>
</data>
<data name="DataTableReadXmlAutogeneratedTitle" xml:space="preserve">
<value>Ensure autogenerated class containing DataTable.ReadXml() is not used with untrusted data</value>
</data>
</root>
22 changes: 5 additions & 17 deletions ...s/Core/Microsoft.NetCore.Analyzers/Security/DataSetDataTableInSerializableTypeAnalyzer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,21 +48,12 @@ public sealed class DataSetDataTableInSerializableTypeAnalyzer : DiagnosticAnaly
RuleLevel.Disabled,
isPortedFxCopRule: false,
isDataflowRule: false);
internal static readonly DiagnosticDescriptor AutogeneratedSerializableContainsDangerousType =
SecurityHelpers.CreateDiagnosticDescriptor(
"CA2363",
nameof(MicrosoftNetCoreAnalyzersResources.DataSetDataTableInAutogeneratedSerializableTypeTitle),
nameof(MicrosoftNetCoreAnalyzersResources.DataSetDataTableInAutogeneratedSerializableTypeMessage),
RuleLevel.Disabled,
isPortedFxCopRule: false,
isDataflowRule: false);

public override ImmutableArray<DiagnosticDescriptor> SupportedDiagnostics =>
ImmutableArray.Create(
RceSerializableContainsDangerousType,
SerializableContainsDangerousType,
RceAutogeneratedSerializableContainsDangerousType,
AutogeneratedSerializableContainsDangerousType);
RceAutogeneratedSerializableContainsDangerousType);

[SuppressMessage("Style", "IDE0047:Remove unnecessary parentheses", Justification = "Group related conditions together.")]
public override void Initialize(AnalysisContext context)
Expand Down Expand Up @@ -171,19 +162,16 @@ public override void Initialize(AnalysisContext context)
out ImmutableArray<InsecureObjectGraphResult> results))
{
DiagnosticDescriptor diagnosticToReport;
if (isProbablyAutogeneratedForGuiApp)
if (hasSerializableAttribute)
{
diagnosticToReport =
hasSerializableAttribute
isProbablyAutogeneratedForGuiApp
? RceAutogeneratedSerializableContainsDangerousType
: AutogeneratedSerializableContainsDangerousType;
: RceSerializableContainsDangerousType;
}
else
{
diagnosticToReport =
hasSerializableAttribute
? RceSerializableContainsDangerousType
: SerializableContainsDangerousType;
diagnosticToReport = SerializableContainsDangerousType;
}

foreach (InsecureObjectGraphResult result in results)
Expand Down
20 changes: 0 additions & 20 deletions ...tAnalyzers/Core/Microsoft.NetCore.Analyzers/xlf/MicrosoftNetCoreAnalyzersResources.cs.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,16 +157,6 @@
<target state="translated">Spolehlivost</target>
<note />
</trans-unit>
<trans-unit id="DataSetDataTableInAutogeneratedSerializableTypeMessage">
<source>When deserializing untrusted input, deserializing a {0} object is insecure. '{1}' either is or derives from {0}. Ensure that the autogenerated type is never deserialized with untrusted data.</source>
<target state="new">When deserializing untrusted input, deserializing a {0} object is insecure. '{1}' either is or derives from {0}. Ensure that the autogenerated type is never deserialized with untrusted data.</target>
<note />
</trans-unit>
<trans-unit id="DataSetDataTableInAutogeneratedSerializableTypeTitle">
<source>Unsafe DataSet or DataTable in autogenerated serializable type</source>
<target state="new">Unsafe DataSet or DataTable in autogenerated serializable type</target>
<note />
</trans-unit>
<trans-unit id="DataSetDataTableInDeserializableObjectGraphMessage">
<source>When deserializing untrusted input, deserializing a {0} object is insecure. '{1}' either is or derives from {0}</source>
<target state="new">When deserializing untrusted input, deserializing a {0} object is insecure. '{1}' either is or derives from {0}</target>
Expand Down Expand Up @@ -247,16 +237,6 @@
<target state="new">Do not use DataSet.ReadXml() with untrusted data</target>
<note />
</trans-unit>
<trans-unit id="DataTableReadXmlAutogeneratedMessage">
<source>The method '{0}' is insecure when deserializing untrusted data. Make sure that autogenerated class containing the '{0}' call is not deserialized with untrusted data.</source>
<target state="new">The method '{0}' is insecure when deserializing untrusted data. Make sure that autogenerated class containing the '{0}' call is not deserialized with untrusted data.</target>
<note />
</trans-unit>
<trans-unit id="DataTableReadXmlAutogeneratedTitle">
<source>Ensure autogenerated class containing DataTable.ReadXml() is not used with untrusted data</source>
<target state="new">Ensure autogenerated class containing DataTable.ReadXml() is not used with untrusted data</target>
<note />
</trans-unit>
<trans-unit id="DataTableReadXmlMessage">
<source>The method '{0}' is insecure when deserializing untrusted data</source>
<target state="new">The method '{0}' is insecure when deserializing untrusted data</target>
Expand Down
20 changes: 0 additions & 20 deletions ...tAnalyzers/Core/Microsoft.NetCore.Analyzers/xlf/MicrosoftNetCoreAnalyzersResources.de.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,16 +157,6 @@
<target state="translated">Zuverlässigkeit</target>
<note />
</trans-unit>
<trans-unit id="DataSetDataTableInAutogeneratedSerializableTypeMessage">
<source>When deserializing untrusted input, deserializing a {0} object is insecure. '{1}' either is or derives from {0}. Ensure that the autogenerated type is never deserialized with untrusted data.</source>
<target state="new">When deserializing untrusted input, deserializing a {0} object is insecure. '{1}' either is or derives from {0}. Ensure that the autogenerated type is never deserialized with untrusted data.</target>
<note />
</trans-unit>
<trans-unit id="DataSetDataTableInAutogeneratedSerializableTypeTitle">
<source>Unsafe DataSet or DataTable in autogenerated serializable type</source>
<target state="new">Unsafe DataSet or DataTable in autogenerated serializable type</target>
<note />
</trans-unit>
<trans-unit id="DataSetDataTableInDeserializableObjectGraphMessage">
<source>When deserializing untrusted input, deserializing a {0} object is insecure. '{1}' either is or derives from {0}</source>
<target state="new">When deserializing untrusted input, deserializing a {0} object is insecure. '{1}' either is or derives from {0}</target>
Expand Down Expand Up @@ -247,16 +237,6 @@
<target state="new">Do not use DataSet.ReadXml() with untrusted data</target>
<note />
</trans-unit>
<trans-unit id="DataTableReadXmlAutogeneratedMessage">
<source>The method '{0}' is insecure when deserializing untrusted data. Make sure that autogenerated class containing the '{0}' call is not deserialized with untrusted data.</source>
<target state="new">The method '{0}' is insecure when deserializing untrusted data. Make sure that autogenerated class containing the '{0}' call is not deserialized with untrusted data.</target>
<note />
</trans-unit>
<trans-unit id="DataTableReadXmlAutogeneratedTitle">
<source>Ensure autogenerated class containing DataTable.ReadXml() is not used with untrusted data</source>
<target state="new">Ensure autogenerated class containing DataTable.ReadXml() is not used with untrusted data</target>
<note />
</trans-unit>
<trans-unit id="DataTableReadXmlMessage">
<source>The method '{0}' is insecure when deserializing untrusted data</source>
<target state="new">The method '{0}' is insecure when deserializing untrusted data</target>
Expand Down
20 changes: 0 additions & 20 deletions ...tAnalyzers/Core/Microsoft.NetCore.Analyzers/xlf/MicrosoftNetCoreAnalyzersResources.es.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,16 +157,6 @@
<target state="translated">Fiabilidad</target>
<note />
</trans-unit>
<trans-unit id="DataSetDataTableInAutogeneratedSerializableTypeMessage">
<source>When deserializing untrusted input, deserializing a {0} object is insecure. '{1}' either is or derives from {0}. Ensure that the autogenerated type is never deserialized with untrusted data.</source>
<target state="new">When deserializing untrusted input, deserializing a {0} object is insecure. '{1}' either is or derives from {0}. Ensure that the autogenerated type is never deserialized with untrusted data.</target>
<note />
</trans-unit>
<trans-unit id="DataSetDataTableInAutogeneratedSerializableTypeTitle">
<source>Unsafe DataSet or DataTable in autogenerated serializable type</source>
<target state="new">Unsafe DataSet or DataTable in autogenerated serializable type</target>
<note />
</trans-unit>
<trans-unit id="DataSetDataTableInDeserializableObjectGraphMessage">
<source>When deserializing untrusted input, deserializing a {0} object is insecure. '{1}' either is or derives from {0}</source>
<target state="new">When deserializing untrusted input, deserializing a {0} object is insecure. '{1}' either is or derives from {0}</target>
Expand Down Expand Up @@ -247,16 +237,6 @@
<target state="new">Do not use DataSet.ReadXml() with untrusted data</target>
<note />
</trans-unit>
<trans-unit id="DataTableReadXmlAutogeneratedMessage">
<source>The method '{0}' is insecure when deserializing untrusted data. Make sure that autogenerated class containing the '{0}' call is not deserialized with untrusted data.</source>
<target state="new">The method '{0}' is insecure when deserializing untrusted data. Make sure that autogenerated class containing the '{0}' call is not deserialized with untrusted data.</target>
<note />
</trans-unit>
<trans-unit id="DataTableReadXmlAutogeneratedTitle">
<source>Ensure autogenerated class containing DataTable.ReadXml() is not used with untrusted data</source>
<target state="new">Ensure autogenerated class containing DataTable.ReadXml() is not used with untrusted data</target>
<note />
</trans-unit>
<trans-unit id="DataTableReadXmlMessage">
<source>The method '{0}' is insecure when deserializing untrusted data</source>
<target state="new">The method '{0}' is insecure when deserializing untrusted data</target>
Expand Down
20 changes: 0 additions & 20 deletions ...tAnalyzers/Core/Microsoft.NetCore.Analyzers/xlf/MicrosoftNetCoreAnalyzersResources.fr.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,16 +157,6 @@
<target state="translated">Fiabilité</target>
<note />
</trans-unit>
<trans-unit id="DataSetDataTableInAutogeneratedSerializableTypeMessage">
<source>When deserializing untrusted input, deserializing a {0} object is insecure. '{1}' either is or derives from {0}. Ensure that the autogenerated type is never deserialized with untrusted data.</source>
<target state="new">When deserializing untrusted input, deserializing a {0} object is insecure. '{1}' either is or derives from {0}. Ensure that the autogenerated type is never deserialized with untrusted data.</target>
<note />
</trans-unit>
<trans-unit id="DataSetDataTableInAutogeneratedSerializableTypeTitle">
<source>Unsafe DataSet or DataTable in autogenerated serializable type</source>
<target state="new">Unsafe DataSet or DataTable in autogenerated serializable type</target>
<note />
</trans-unit>
<trans-unit id="DataSetDataTableInDeserializableObjectGraphMessage">
<source>When deserializing untrusted input, deserializing a {0} object is insecure. '{1}' either is or derives from {0}</source>
<target state="new">When deserializing untrusted input, deserializing a {0} object is insecure. '{1}' either is or derives from {0}</target>
Expand Down Expand Up @@ -247,16 +237,6 @@
<target state="new">Do not use DataSet.ReadXml() with untrusted data</target>
<note />
</trans-unit>
<trans-unit id="DataTableReadXmlAutogeneratedMessage">
<source>The method '{0}' is insecure when deserializing untrusted data. Make sure that autogenerated class containing the '{0}' call is not deserialized with untrusted data.</source>
<target state="new">The method '{0}' is insecure when deserializing untrusted data. Make sure that autogenerated class containing the '{0}' call is not deserialized with untrusted data.</target>
<note />
</trans-unit>
<trans-unit id="DataTableReadXmlAutogeneratedTitle">
<source>Ensure autogenerated class containing DataTable.ReadXml() is not used with untrusted data</source>
<target state="new">Ensure autogenerated class containing DataTable.ReadXml() is not used with untrusted data</target>
<note />
</trans-unit>
<trans-unit id="DataTableReadXmlMessage">
<source>The method '{0}' is insecure when deserializing untrusted data</source>
<target state="new">The method '{0}' is insecure when deserializing untrusted data</target>
Expand Down
20 changes: 0 additions & 20 deletions ...tAnalyzers/Core/Microsoft.NetCore.Analyzers/xlf/MicrosoftNetCoreAnalyzersResources.it.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,16 +157,6 @@
<target state="translated">Affidabilità</target>
<note />
</trans-unit>
<trans-unit id="DataSetDataTableInAutogeneratedSerializableTypeMessage">
<source>When deserializing untrusted input, deserializing a {0} object is insecure. '{1}' either is or derives from {0}. Ensure that the autogenerated type is never deserialized with untrusted data.</source>
<target state="new">When deserializing untrusted input, deserializing a {0} object is insecure. '{1}' either is or derives from {0}. Ensure that the autogenerated type is never deserialized with untrusted data.</target>
<note />
</trans-unit>
<trans-unit id="DataSetDataTableInAutogeneratedSerializableTypeTitle">
<source>Unsafe DataSet or DataTable in autogenerated serializable type</source>
<target state="new">Unsafe DataSet or DataTable in autogenerated serializable type</target>
<note />
</trans-unit>
<trans-unit id="DataSetDataTableInDeserializableObjectGraphMessage">
<source>When deserializing untrusted input, deserializing a {0} object is insecure. '{1}' either is or derives from {0}</source>
<target state="new">When deserializing untrusted input, deserializing a {0} object is insecure. '{1}' either is or derives from {0}</target>
Expand Down Expand Up @@ -247,16 +237,6 @@
<target state="new">Do not use DataSet.ReadXml() with untrusted data</target>
<note />
</trans-unit>
<trans-unit id="DataTableReadXmlAutogeneratedMessage">
<source>The method '{0}' is insecure when deserializing untrusted data. Make sure that autogenerated class containing the '{0}' call is not deserialized with untrusted data.</source>
<target state="new">The method '{0}' is insecure when deserializing untrusted data. Make sure that autogenerated class containing the '{0}' call is not deserialized with untrusted data.</target>
<note />
</trans-unit>
<trans-unit id="DataTableReadXmlAutogeneratedTitle">
<source>Ensure autogenerated class containing DataTable.ReadXml() is not used with untrusted data</source>
<target state="new">Ensure autogenerated class containing DataTable.ReadXml() is not used with untrusted data</target>
<note />
</trans-unit>
<trans-unit id="DataTableReadXmlMessage">
<source>The method '{0}' is insecure when deserializing untrusted data</source>
<target state="new">The method '{0}' is insecure when deserializing untrusted data</target>
Expand Down
Loading