Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Naming Styles for editorconfig UI #58075

Merged
merged 26 commits into from
Dec 7, 2021
Merged

Implement Naming Styles for editorconfig UI #58075

merged 26 commits into from
Dec 7, 2021

Commits on Dec 1, 2021

  1. move Language enum further down the stack

    @jmarolf
    jmarolf committed Dec 1, 2021
    Configuration menu
    Copy the full SHA
    883a2c5 View commit details
    Browse the repository at this point in the history

Commits on Dec 2, 2021

  1. implement naming styles option parser with text span support

    @jmarolf
    jmarolf committed Dec 2, 2021
    29 Configuration menu
    Copy the full SHA
    d77a8f8 View commit details
    Browse the repository at this point in the history

  2. add folder description

    @jmarolf
    jmarolf committed Dec 2, 2021
    Configuration menu
    Copy the full SHA
    a7e051a View commit details
    Browse the repository at this point in the history

  3. Add namging style option support 

    This adds all the capabilities necessary to discover and update naming styles in an editorconfig. depends on the parser functionality added in previous commit
    @jmarolf
    jmarolf committed Dec 2, 2021
    Configuration menu
    Copy the full SHA
    5e5cbc8 View commit details
    Browse the repository at this point in the history

  4. add folder description

    @jmarolf
    jmarolf committed Dec 2, 2021
    Configuration menu
    Copy the full SHA
    682a9df View commit details
    Browse the repository at this point in the history

  5. Add views for naming styles 

    This adds a new tab for the naming style options that were exposed via services in a previous commit
    @jmarolf
    jmarolf committed Dec 2, 2021
    1 Configuration menu
    Copy the full SHA
    a773abe View commit details
    Browse the repository at this point in the history

  6. Update src/Workspaces/SharedUtilitiesAndExtensions/Compiler/Core/Nami… 

    …ngStyles/EditorConfig/EditorConfigNamingStyleParser_NamingStyle.cs

Co-authored-by: Joey Robichaud <jorobich@microsoft.com>
    @jmarolf @JoeRobich
    jmarolf and JoeRobich committed Dec 2, 2021
    Configuration menu
    Copy the full SHA
    48f54b4 View commit details
    Browse the repository at this point in the history

  7. Update src/Workspaces/SharedUtilitiesAndExtensions/Compiler/Core/Edit… 

    …orConfig/readme.md

Co-authored-by: Joey Robichaud <jorobich@microsoft.com>
    @jmarolf @JoeRobich
    jmarolf and JoeRobich committed Dec 2, 2021
    Configuration menu
    Copy the full SHA
    1886364 View commit details
    Browse the repository at this point in the history

  8. Update src/EditorFeatures/Core/EditorConfigSettings/Updater/NamingSty… 

    …les/EditorConfigNamingStylesExtensions.cs

Co-authored-by: Youssef Victor <youssefvictor00@gmail.com>
    @jmarolf @Youssef1313
    jmarolf and Youssef1313 committed Dec 2, 2021
    Configuration menu
    Copy the full SHA
    49088b0 View commit details
    Browse the repository at this point in the history

  9. Update src/EditorFeatures/Core/EditorConfigSettings/Updater/NamingSty… 

    …les/EditorConfigNamingStylesExtensions.cs

Co-authored-by: Youssef Victor <youssefvictor00@gmail.com>
    @jmarolf @Youssef1313
    jmarolf and Youssef1313 committed Dec 2, 2021
    Configuration menu
    Copy the full SHA
    da90d81 View commit details
    Browse the repository at this point in the history

  10. lengthen the search box to align with the tabs above it

    @jmarolf
    jmarolf committed Dec 2, 2021
    Configuration menu
    Copy the full SHA
    3a28801 View commit details
    Browse the repository at this point in the history

  11. enable nullable on test files

    @jmarolf
    jmarolf committed Dec 2, 2021
    Configuration menu
    Copy the full SHA
    cbce098 View commit details
    Browse the repository at this point in the history

  12. de-duplicate local functions

    @jmarolf
    jmarolf committed Dec 2, 2021
    Configuration menu
    Copy the full SHA
    525cb16 View commit details
    Browse the repository at this point in the history

  13. simplify boolean logic

    @jmarolf
    jmarolf committed Dec 2, 2021
    Configuration menu
    Copy the full SHA
    03da9e5 View commit details
    Browse the repository at this point in the history

  14. use resource strings in tests

    @jmarolf
    jmarolf committed Dec 2, 2021
    Configuration menu
    Copy the full SHA
    98006e6 View commit details
    Browse the repository at this point in the history

  15. return immutable array for static severities

    @jmarolf
    jmarolf committed Dec 2, 2021
    Configuration menu
    Copy the full SHA
    b53f7d1 View commit details
    Browse the repository at this point in the history

Commits on Dec 3, 2021

  1. update readme with a relative path link

    @jmarolf
    jmarolf committed Dec 3, 2021
    Configuration menu
    Copy the full SHA
    74e9ca0 View commit details
    Browse the repository at this point in the history

  2. using TryPeekNext

    @jmarolf
    jmarolf committed Dec 3, 2021
    Configuration menu
    Copy the full SHA
    761eb1e View commit details
    Browse the repository at this point in the history

  3. using disposeable pooled objects

    @jmarolf
    jmarolf committed Dec 3, 2021
    Configuration menu
    Copy the full SHA
    ba7bdb3 View commit details
    Browse the repository at this point in the history

  4. renamge rangeOpt to numberRange

    @jmarolf
    jmarolf committed Dec 3, 2021
    Configuration menu
    Copy the full SHA
    2c9fed1 View commit details
    Browse the repository at this point in the history

Commits on Dec 6, 2021

  1. fix Span and Section being swapped from the base

    @jmarolf
    jmarolf committed Dec 6, 2021
    Configuration menu
    Copy the full SHA
    264eefb View commit details
    Browse the repository at this point in the history

  2. update incorrect comment

    @jmarolf
    jmarolf committed Dec 6, 2021
    Configuration menu
    Copy the full SHA
    b2ca734 View commit details
    Browse the repository at this point in the history

  3. Combine Lex with static function

    @jmarolf
    jmarolf committed Dec 6, 2021
    Configuration menu
    Copy the full SHA
    a321a3f View commit details
    Browse the repository at this point in the history

  4. return false if we fail to determine the language for a path

    @jmarolf
    jmarolf committed Dec 6, 2021
    Configuration menu
    Copy the full SHA
    132f6b0 View commit details
    Browse the repository at this point in the history

  5. use Lazy instead of fancy InterlockedInitialize

    @jmarolf
    jmarolf committed Dec 6, 2021
    Configuration menu
    Copy the full SHA
    cb5cfc0 View commit details
    Browse the repository at this point in the history

Commits on Dec 7, 2021

  1. move search bar up by 12 pixels

    @jmarolf
    jmarolf committed Dec 7, 2021
    Configuration menu
    Copy the full SHA
    86ef543 View commit details
    Browse the repository at this point in the history