Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix symbol completions after required keyword #64593

Merged
merged 2 commits into from
Oct 10, 2022
Merged

Fix symbol completions after required keyword #64593

merged 2 commits into from
Oct 10, 2022

Conversation

DoctorKrolic
Copy link
Contributor

Fixes: #64585

@DoctorKrolic DoctorKrolic requested a review from a team as a code owner October 9, 2022 08:17
@ghost ghost added the Community The pull request was submitted by a contributor who is not a Microsoft employee. label Oct 9, 2022
@build-analysis build-analysis bot mentioned this pull request Oct 10, 2022
Closed
@DoctorKrolic
Copy link
Contributor Author

@CyrusNajmabadi Restart CI pls. The maintenance is over, right?

@CyrusNajmabadi CyrusNajmabadi changed the title Fix symbol colpletions after required keyword Fix symbol completions after required keyword Oct 10, 2022
@CyrusNajmabadi CyrusNajmabadi changed the title Fix symbol completions after required keyword Fix symbol completions after required keyword Oct 10, 2022
@CyrusNajmabadi CyrusNajmabadi merged commit 91a2af3 into dotnet:main Oct 10, 2022
@ghost ghost added this to the Next milestone Oct 10, 2022
@DoctorKrolic DoctorKrolic deleted the completions-after-required branch October 10, 2022 19:31
@allisonchou allisonchou mentioned this pull request Oct 11, 2022
Closed
@RikkiGibson RikkiGibson modified the milestones: Next, 17.5 P1 Oct 24, 2022
@Youssef1313 Youssef1313 mentioned this pull request Nov 22, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CyrusNajmabadi CyrusNajmabadi CyrusNajmabadi approved these changes

Assignees
No one assigned
Labels
Area-IDE Community The pull request was submitted by a contributor who is not a Microsoft employee.
Projects
None yet
Milestone
17.5 P1
Development

Successfully merging this pull request may close these issues.

No type completion after required modifier
3 participants
@DoctorKrolic @CyrusNajmabadi @RikkiGibson