Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always take ownership from UIThreadContext when rename commit #74889

Merged
merged 10 commits into from
Aug 28, 2024

Conversation

Cosifne
Copy link
Member

@Cosifne Cosifne commented Aug 24, 2024

In the current build, if the rename commit takes long time, when the commit is not triggered by 'enter'.
Your won't be able to cancel the operation.

Before:
CancelNoEffect

After:
CancelEffect

It happens when I type 'ctrl + s' to commit the rename.

Fix is always taking ownership from the UIContext when commit starts.
We already do this in enter command handler,

Later rename session would choose to use IUIThreadOperationContext or IBackgroundIndicator by itself.

@Cosifne Cosifne requested a review from a team as a code owner August 24, 2024 02:16
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Aug 24, 2024
@Cosifne Cosifne enabled auto-merge August 27, 2024 19:01
@Cosifne Cosifne disabled auto-merge August 27, 2024 22:17
@Cosifne Cosifne merged commit edadee5 into dotnet:main Aug 28, 2024
25 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Aug 28, 2024
@Cosifne Cosifne deleted the dev/shech/TakeOnwershipWhenRename branch August 28, 2024 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants