Remove MS.CA.Test.Resources.Proprietary PackageReference #75037
Conversation
This package is the last remnants of the roslyn-internal repository. It was still holding onto a few test assets that never got ported into the open but were available through the NuPkg reference. This package is becoming a problem with component governance as it is a `netstandard1.3` package and hence brings in a lot of vulnerable components. Considered upgrading this package to `netstandard2.0` but that would mean un-archiving the roslyn-internal repo, finding a place to put the source code and setting up a new official pipeline for the package. That is a pretty high price. Instead I decided to finish the work that I should've completed a number of years ago. Yes this does add a few more .dll into our git tree. These are files that haven't changed in 10+ years so versioning won't be an issue. They were all brought down already for restore hence it's not new files.
dotnet-issue-labeler
bot
added
Area-Compilers
untriaged
| /// to know that two mscorlib with different public key tokens need to be treated as the | ||
| /// identicial. The assemblies produced here have the same identity of those that come | ||
| /// from silverlight but without necessarily the same type contents. | ||
| /// </summary> |
There was a problem hiding this comment.
I went back and forth on this decision several times. The Silverlight references are only used right now to test assembly unification policies (that I could see). Rather than the overhead of bringing in more .dll files decided to just dynamically build the same assemblies that would let us test unification policy.
| @@ -85,11 +86,16 @@ | |||
| <Content Include="NetFX\aacorlib\Key.snk" /> | |||
| <EmbeddedResource Include="NetFX\Minimal\minasync.dll" /> | |||
| <EmbeddedResource Include="NetFX\Minimal\mincorlib.dll" /> | |||
| <EmbeddedResource Include="NetFX\PortableProfile7\mscorlib.dll" /> | |||
| <EmbeddedResource Include="NetFX\PortableProfile7\System.Runtime.dll" /> | |||
There was a problem hiding this comment.
Attempted to add a portable7 variant to Basic.Reference.Assemblies but these aren't available through NuPkg anywhere. Decided to just use them directly as resources.
| <EmbeddedResource Include="NetFX\PortableProfile7\mscorlib.dll" /> | ||
| <EmbeddedResource Include="NetFX\PortableProfile7\System.Runtime.dll" /> | ||
| <EmbeddedResource Include="NetFX\WinRt\System.Runtime.WindowsRuntime.dll" /> | ||
| <EmbeddedResource Include="NetFX\WinRt\System.Runtime.WindowsRuntime.UI.Xaml.dll" /> |
There was a problem hiding this comment.
These two references are available as NuPkg and in theory could be added to the extra sections of Basic.Reference.Assemblies.Net461. Unfortunately, there is a substantial difference between how idiomatic net461 WinRt projects build using these references and how our tests build. The tests do not use the standard reference versions of these DLLs and using the standard references causes the tests to break. Decided to keep the existing DLLs to maintain test behavior.
| @@ -15,6 +15,7 @@ | |||
| </PropertyGroup> | |||
| <ItemGroup Label="Project References"> | |||
| <ProjectReference Include="..\..\..\Core\Portable\Microsoft.CodeAnalysis.csproj" /> | |||
| <PackageReference Include="stdole" IncludeAssets="none" PrivateAssets="all" GeneratePathProperty="true" /> | |||
There was a problem hiding this comment.
This is not a .NET framework NuPkg hence redist directly within our repo is a bit suspect. Decided on the embed the NuPkg resource approach.
| private static readonly Lazy<MetadataReference> s_mscorlibRefPortable = new Lazy<MetadataReference>( | ||
| () => AssemblyMetadata.CreateFromImage(ProprietaryTestResources.v4_0_30319.mscorlib_portable).GetReference(display: "mscorlib.v4_0_30319.portable.dll"), | ||
| LazyThreadSafetyMode.PublicationOnly); | ||
| public static MetadataReference MscorlibRefPortable => s_mscorlibRefPortable.Value; |
There was a problem hiding this comment.
This reference was primarily used for situations in the compiler where we needed a System.String type that lacked the GetEnumerator method. This setup for String is also present in the PortableProfile7 API (though corelib is System.Runtime.dll there). Moved compiler tests over to use that.
This was used in the symbol finder tests in the IDE but that doesn't appear to be anything specific to the portable library. Instead it was used because the symbol finder tests need to deal with retargeting between different core libraries. Flipped those to mostly use net40 and net461 mscorlib.
https://vstfdevdiv.corp.microsoft.com/DevDiv2/DevDiv/_workitems/edit/667616
|
@dotnet/roslyn-compiler PTAL |
|
|
||
| return ImmutableCollectionsMarshal.AsImmutableArray(bytes); | ||
|
|
||
| byte parseByte(ReadOnlySpan<char> input, NumberStyles numberStyle) |
There was a problem hiding this comment.
Following up on this in the audit PR
| { | ||
| const string corlibExtraCode = """ | ||
| using System; | ||
| using System.Reflection; |
There was a problem hiding this comment.
Nit: these usings look unnecessary. Maybe adding VerifyDiagnostics to the compilations we create here would catch that?
* upstream/main: (45 commits) Adjust an assert in EmitArgument (dotnet#75067) Switch to new VMR control set (dotnet#75056) Disallow ref assignment to ternary or another ref assignment (dotnet#75076) Move some emit tests from Emit2 to Emit3 to avoid hitting UserString heap limit (dotnet#75091) BindAttributeCore - use proper binder to avoid an attribute binding cycle (dotnet#75060) Remove buggy IsPublic method from TypeAttributesExtensions (dotnet#75081) Include initial filter node when searching for nodes to order modifiers Remove additional Gitter link (dotnet#75086) Remove newlines between test run information sections Log messages for Test Results Fix stack adjustment when emitting stackalloc (dotnet#75042) Lock translation of strings used to demonstrate identifier naming styles docs: Correct SDK version in documentation to match global.json (dotnet#75038) Add a test observing lack of an issue. (dotnet#75057) Fix preview refresh on selection for enum flags checkboxes Semantic snippets: handle case with inline statement snippets before member access expression (dotnet#74966) Configure release/vscode branch for nuget publishing Remove MS.CA.Test.Resources.Proprietary PackageReference (dotnet#75037) Allow suppressing nullability warnings in more ref scenarios (dotnet#74498) Update dependencies from https://github.com/dotnet/arcade build 20240909.6 (dotnet#75040) ...
This package is the last remnants of the roslyn-internal repository. It was still holding onto a few test assets that never got ported into the open but were available through the NuPkg reference.
This package is becoming a problem with component governance as it is a
netstandard1.3package and hence brings in a lot of vulnerable components.Considered upgrading this package to
netstandard2.0but that would mean un-archiving the roslyn-internal repo, finding a place to put the source code and setting up a new official pipeline for the package. That is a pretty high price. Instead I decided to finish the work that I should've completed a number of years ago.Yes this does add a few more .dll into our git tree. These are files that haven't changed in 10+ years so versioning won't be an issue. They were all brought down already for restore hence it's not new files.