Fix the SmartRename button regressions #75134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oyang/fixRenameButton
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
dotnet-policy-service
bot
added
Community
3 tasks
Cosifne
reviewed
Sep 16, 2024
| @@ -87,7 +87,6 @@ | |||
| </Trigger> | |||
| <Trigger Property="IsKeyboardFocused" Value="true"> | |||
| <Setter Property="BorderBrush" Value="{DynamicResource {x:Static vsui:CommonControlsColors.ButtonBorderFocusedBrushKey}}"/> | |||
| <Setter Property="Background" Value="{DynamicResource {x:Static vsui:CommonControlsColors.ButtonFocusedBrushKey}}"/> | |||
There was a problem hiding this comment.
@Cosifne Hi, we want to make it consistent with the panel expand case (Purple), and different with the panel collapse case. It decreases the confusion.
After removing the focus background, the button will be purple when focused. And the light border can indicate whether the button is focused.
There was a problem hiding this comment.
Could you verify if the color still looks correct when in light/blue theme?
Cosifne
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fix the SmartRename button regressions: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/2112161/
When
IsAutomaticSuggestionsEnabledis ONButton toggled => suggestion panel collapse
Button not toggled = > suggestion panel expand
2 Button UI when Hover / Focus / toggle / click
Click => lighter border + purple background (indicate
IsAutomaticSuggestionsEnabledis ON)Focus => lighter border
Toggle => lighter border + grey background
Hover => grey background
In blue and light theme
