Test EnC document diagnostics in non-host workspace #75140
Merged
+32
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-Interactive
untriaged
tmat
force-pushed
the
EncDiagsWorkspaceKind-Test
branch
from
7095b59
to
1e2ba80
Compare
tmat
changed the title
tmat
commented
Sep 16, 2024
| @@ -354,11 +354,6 @@ private async Task<TestLspServer> CreateTestLspServerAsync(EditorTestWorkspace w | |||
| solution = solution.WithAnalyzerReferences([analyzerReferencesByLanguage]); | |||
| await workspace.ChangeSolutionAsync(solution); | |||
|
|
|||
| // Important: We must wait for workspace creation operations to finish. | |||
There was a problem hiding this comment.
Moved to CreateAsync - all callers of it had this code.
dibarbet
approved these changes
Sep 16, 2024
tmat
force-pushed
the
EncDiagsWorkspaceKind-Test
branch
from
1e2ba80
to
1cde5e3
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.