-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[iOS] Clean up sample build when AOT+LLVM is enabled #54572
Comments
Tagging subscribers to this area: @directhex Issue DetailsBy default the AppleAppBuilder will add We should clean this up a bit and try to make it similar to the test build.
|
Adding everything from bin was intentional, as part of #52372, to fix tests failing due to missing subdirectories (i.e. test data not being included) Your thought is we should be explicitly filtering out |
Yes, in the test build the .o files are in the obj directory and aren't included. |
By default the AppleAppBuilder will add
-llvm.o
files totarget_link_libraries
in CMakeLists. This works great for tests, but not for the sample because we are picking up all files frombin
and adding them toAPP_RESOURCES
.We should clean this up a bit and try to make it similar to the test build.
The text was updated successfully, but these errors were encountered: