Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] Clean up sample build when AOT+LLVM is enabled #54572

Closed
steveisok opened this issue Jun 22, 2021 · 3 comments · Fixed by #54856
Closed

[iOS] Clean up sample build when AOT+LLVM is enabled #54572

steveisok opened this issue Jun 22, 2021 · 3 comments · Fixed by #54856
Assignees
Milestone

Comments

@steveisok
Copy link
Member

By default the AppleAppBuilder will add -llvm.o files to target_link_libraries in CMakeLists. This works great for tests, but not for the sample because we are picking up all files from bin and adding them to APP_RESOURCES.

We should clean this up a bit and try to make it similar to the test build.

@steveisok steveisok added this to the 6.0.0 milestone Jun 22, 2021
@ghost
Copy link

ghost commented Jun 22, 2021

Tagging subscribers to this area: @directhex
See info in area-owners.md if you want to be subscribed.

Issue Details

By default the AppleAppBuilder will add -llvm.o files to target_link_libraries in CMakeLists. This works great for tests, but not for the sample because we are picking up all files from bin and adding them to APP_RESOURCES.

We should clean this up a bit and try to make it similar to the test build.

Author: steveisok
Assignees: -
Labels:

area-Infrastructure-mono

Milestone: 6.0.0

@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label Jun 22, 2021
@steveisok steveisok removed the untriaged New issue has not been triaged by the area owner label Jun 22, 2021
@directhex
Copy link
Member

Adding everything from bin was intentional, as part of #52372, to fix tests failing due to missing subdirectories (i.e. test data not being included)

Your thought is we should be explicitly filtering out -llvm.o suffixed files from AppResources?

@steveisok
Copy link
Member Author

Yes, in the test build the .o files are in the obj directory and aren't included.

@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Jun 28, 2021
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Jun 30, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Jul 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants