Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wasm][aot] Windows: Test failures for System.Globalization.Extensions.Tests #58708

Closed
radical opened this issue Sep 6, 2021 · 2 comments · Fixed by #71077
Closed

[wasm][aot] Windows: Test failures for System.Globalization.Extensions.Tests #58708

radical opened this issue Sep 6, 2021 · 2 comments · Fixed by #71077
Assignees
@radekdoulik
Labels
arch-wasm WebAssembly architecture area-System.Globalization wasm-aot-test WebAssembly AOT Test
Milestone
7.0.0

Comments

@radical
Copy link
Member

radical commented Sep 6, 2021

PR to enable AOT tests on windows: #58578

Build
Log

[02:31:36] fail: [FAIL] System.Globalization.Tests.IdnMappingIdnaConformanceTests.GetAscii_Success
[02:31:36] info: System.ArgumentOutOfRangeException : Specified argument was out of the range of valid values.
[02:31:36] info:    at System.Globalization.Tests.Factory.ParseFile(Stream stream, Func`3 f)+MoveNext()
[02:31:36] info:    at System.Globalization.Tests.Factory.GetDataset()+MoveNext()
[02:31:36] info:    at System.Linq.Enumerable.WhereEnumerableIterator`1[[System.Globalization.Tests.IConformanceIdnaTest, System.Globalization.Extensions.Tests, Version=6.0.0.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51]].MoveNext()
[02:31:37] info:    at System.Collections.Generic.LargeArrayBuilder`1[[System.Globalization.Tests.IConformanceIdnaTest, System.Globalization.Extensions.Tests, Version=6.0.0.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51]].AddRange(IEnumerable`1 )
[02:31:37] info:    at System.Collections.Generic.EnumerableHelpers.ToArray[IConformanceIdnaTest](IEnumerable`1 )
[02:31:37] info:    at System.Linq.Enumerable.ToArray[IConformanceIdnaTest](IEnumerable`1 source)
[02:31:37] info:    at System.Reflection.RuntimeMethodInfo.Invoke(Object , BindingFlags , Binder , Object[] , CultureInfo )
[02:31:37] fail: [FAIL] System.Globalization.Tests.IdnMappingIdnaConformanceTests.GetUnicode_Success
[02:31:37] info: System.ArgumentOutOfRangeException : Specified argument was out of the range of valid values.
[02:31:37] info:    at System.Globalization.Tests.Factory.ParseFile(Stream stream, Func`3 f)+MoveNext()
[02:31:37] info:    at System.Globalization.Tests.Factory.GetDataset()+MoveNext()
[02:31:37] info:    at System.Linq.Enumerable.WhereEnumerableIterator`1[[System.Globalization.Tests.IConformanceIdnaTest, System.Globalization.Extensions.Tests, Version=6.0.0.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51]].MoveNext()
[02:31:37] info:    at System.Collections.Generic.LargeArrayBuilder`1[[System.Globalization.Tests.IConformanceIdnaTest, System.Globalization.Extensions.Tests, Version=6.0.0.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51]].AddRange(IEnumerable`1 )
[02:31:37] info:    at System.Collections.Generic.EnumerableHelpers.ToArray[IConformanceIdnaTest](IEnumerable`1 )
[02:31:37] info:    at System.Linq.Enumerable.ToArray[IConformanceIdnaTest](IEnumerable`1 source)
[02:31:37] info:    at System.Reflection.RuntimeMethodInfo.Invoke(Object , BindingFlags , Binder , Object[] , CultureInfo )
[02:31:37] fail: [FAIL] System.Globalization.Tests.IdnMappingIdnaConformanceTests.GetUnicode_Invalid
[02:31:37] info: System.ArgumentOutOfRangeException : Specified argument was out of the range of valid values.
[02:31:37] info:    at System.Globalization.Tests.Factory.ParseFile(Stream stream, Func`3 f)+MoveNext()
[02:31:37] info:    at System.Globalization.Tests.Factory.GetDataset()+MoveNext()
[02:31:37] info:    at System.Linq.Enumerable.WhereEnumerableIterator`1[[System.Globalization.Tests.IConformanceIdnaTest, System.Globalization.Extensions.Tests, Version=6.0.0.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51]].MoveNext()
[02:31:37] info:    at System.Collections.Generic.LargeArrayBuilder`1[[System.Globalization.Tests.IConformanceIdnaTest, System.Globalization.Extensions.Tests, Version=6.0.0.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51]].AddRange(IEnumerable`1 )
[02:31:37] info:    at System.Collections.Generic.EnumerableHelpers.ToArray[IConformanceIdnaTest](IEnumerable`1 )
[02:31:37] info:    at System.Linq.Enumerable.ToArray[IConformanceIdnaTest](IEnumerable`1 source)
[02:31:37] info:    at System.Reflection.RuntimeMethodInfo.Invoke(Object , BindingFlags , Binder , Object[] , CultureInfo )
[02:31:37] fail: [FAIL] System.Globalization.Tests.IdnMappingIdnaConformanceTests.GetAscii_Invalid
[02:31:37] info: System.ArgumentOutOfRangeException : Specified argument was out of the range of valid values.
[02:31:37] info:    at System.Globalization.Tests.Factory.ParseFile(Stream stream, Func`3 f)+MoveNext()
[02:31:37] info:    at System.Globalization.Tests.Factory.GetDataset()+MoveNext()
[02:31:37] info:    at System.Linq.Enumerable.WhereEnumerableIterator`1[[System.Globalization.Tests.IConformanceIdnaTest, System.Globalization.Extensions.Tests, Version=6.0.0.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51]].MoveNext()
[02:31:37] info:    at System.Collections.Generic.LargeArrayBuilder`1[[System.Globalization.Tests.IConformanceIdnaTest, System.Globalization.Extensions.Tests, Version=6.0.0.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51]].AddRange(IEnumerable`1 )
[02:31:37] info:    at System.Collections.Generic.EnumerableHelpers.ToArray[IConformanceIdnaTest](IEnumerable`1 )
[02:31:37] info:    at System.Linq.Enumerable.ToArray[IConformanceIdnaTest](IEnumerable`1 source)
[02:31:37] info:    at System.Reflection.RuntimeMethodInfo.Invoke(Object , BindingFlags , Binder , Object[] , CultureInfo )
[02:31:42] info: Finished:    System.Globalization.Extensions.Tests.dll
[02:31:42] info: 
[02:31:42] info: === TEST EXECUTION SUMMARY ===
[02:31:42] info: Total: 290, Errors: 0, Failed: 4, Skipped: 0, Time: 6.257763s
@radical radical added arch-wasm WebAssembly architecture wasm-aot-test WebAssembly AOT Test labels Sep 6, 2021
@dotnet-issue-labeler dotnet-issue-labeler bot added area-System.Globalization untriaged New issue has not been triaged by the area owner labels Sep 6, 2021
@radical
Copy link
Member Author

radical commented Sep 6, 2021

cc @lewing @radekdoulik

@lewing lewing added this to the 7.0.0 milestone Sep 7, 2021
@lewing lewing removed the untriaged New issue has not been triaged by the area owner label Sep 7, 2021
@radical radical added disabled-test The test is disabled in source code against the issue and removed disabled-test The test is disabled in source code against the issue labels Sep 7, 2021
radical added a commit to radical/runtime that referenced this issue Nov 7, 2021
@radical
[wasm] Disable failing tests for AOT/windows
fd4f07f 
https//github.com/dotnet/issues/58707
https//github.com/dotnet/issues/58708
@ilonatommy
Copy link
Member

ilonatommy commented Jun 21, 2022 •
edited
Loading

After enabling all 4 tests on current main, they are passing. Tested with:
dotnet build /t:Test src/libraries/System.Globalization.Extensions/tests /p:TargetOS=Browser /p:Configuration=Release /p:RunAOTCompilation=true /p:BrowserHost=Windows, planning to open a PR to enable them back.

@ilonatommy ilonatommy mentioned this issue Jun 21, 2022
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Jun 21, 2022
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Jun 21, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Jul 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@radekdoulik radekdoulik

Labels
arch-wasm WebAssembly architecture area-System.Globalization wasm-aot-test WebAssembly AOT Test
Projects
None yet
Milestone
7.0.0
Development

Successfully merging a pull request may close this issue.

[wasm][aot] Enabled System.Globalization.Extensions.Tests ilonatommy/runtime
4 participants
@radical @lewing @radekdoulik @ilonatommy