Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wasm] Surface errors from emcc --version, like missing python #61067

Closed
radical opened this issue Nov 1, 2021 · 1 comment · Fixed by #61276
Closed

[wasm] Surface errors from emcc --version, like missing python #61067

radical opened this issue Nov 1, 2021 · 1 comment · Fixed by #61276
Assignees
Labels
arch-wasm WebAssembly architecture area-Build-mono

Comments

@radical
Copy link
Member

radical commented Nov 1, 2021

Based on #60274 .

Missing python, for example, shows up in the logs as:

Environment Variables passed to tool: (TaskId:476)
...
  PATH=/usr/share/dotnet/packs/Microsoft.NET.Runtime.Emscripten.2.0.23.Node.linux-x64/6.0.0-rc.2.21474.1/Sdk/../tools/bin:/usr/share/dotnet/packs/Microsoft.NET.Runtime.Emscripten.2.0.23.Sdk.linux-x64/6.0.0-rc.2.21474.1/Sdk/../tools/bin:/usr/share/dotnet/packs/Microsoft.NET.Runtime.Emscripten.2.0.23.Sdk.linux-x64/6.0.0-rc.2.21474.1/Sdk/../tools/emscripten:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin (TaskId:476)

emcc --version (TaskId:476)
unable to find python in $PATH (TaskId:476)

.. but for the user:

dotnet/packs/Microsoft.NET.Runtime.WebAssembly.Sdk/6.0.0-rc.1.21451.13/Sdk/WasmApp.Native.targets(394,5):
  error MSB3073: The command "emcc --version" exited with code 1. 
@radical radical added arch-wasm WebAssembly architecture area-Build-mono labels Nov 1, 2021
@ghost
Copy link

ghost commented Nov 1, 2021

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Based on #60274 .

Missing python, for example, shows up in the logs as:

Environment Variables passed to tool: (TaskId:476)
...
  PATH=/usr/share/dotnet/packs/Microsoft.NET.Runtime.Emscripten.2.0.23.Node.linux-x64/6.0.0-rc.2.21474.1/Sdk/../tools/bin:/usr/share/dotnet/packs/Microsoft.NET.Runtime.Emscripten.2.0.23.Sdk.linux-x64/6.0.0-rc.2.21474.1/Sdk/../tools/bin:/usr/share/dotnet/packs/Microsoft.NET.Runtime.Emscripten.2.0.23.Sdk.linux-x64/6.0.0-rc.2.21474.1/Sdk/../tools/emscripten:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin (TaskId:476)

emcc --version (TaskId:476)
unable to find python in $PATH (TaskId:476)

.. but for the user:

dotnet/packs/Microsoft.NET.Runtime.WebAssembly.Sdk/6.0.0-rc.1.21451.13/Sdk/WasmApp.Native.targets(394,5):
  error MSB3073: The command "emcc --version" exited with code 1. 
Author: radical
Assignees: -
Labels:

arch-wasm, area-Build-mono

Milestone: -

@radical radical self-assigned this Nov 1, 2021
@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label Nov 1, 2021
@lewing lewing removed the untriaged New issue has not been triaged by the area owner label Nov 1, 2021
radical added a commit to radical/runtime that referenced this issue Nov 9, 2021
We can use the captured output from the `Exec` task, but it would have
to be weirdly formatted to get the proper looking errors. Instead, since
the command itself is light, we just run it again, and this time surface
the output as Errors.

Fixes dotnet#61067
radical added a commit that referenced this issue Nov 10, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Dec 10, 2021
radical added a commit to radical/runtime that referenced this issue Feb 7, 2022
Fixes dotnet#61067
Fixes dotnet#59538

(cherry picked from commit 43c3e9a79a241d044f747373bf483da23807afff)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-Build-mono
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants