Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing test Microsoft.Extensions.Caching.Memory.CapacityTests.AddingReplacementWhenTotalSizeExceedsCapacityDoesNotUpdateRemovesOldEntryAndTriggersCompaction #72912

Open
radical opened this issue Jul 27, 2022 · 4 comments
Labels
area-Extensions-Caching disabled-test The test is disabled in source code against the issue test-failure
Milestone

Comments

@radical
Copy link
Member

radical commented Jul 27, 2022

Hit with Libraries Test Run release coreclr windows x86 Release on #72892 .
build, and log:

  Starting:    Microsoft.Extensions.Caching.Memory.Tests (parallel test collections = on, max threads = 2)
    Microsoft.Extensions.Caching.Memory.CapacityTests.AddingReplacementWhenTotalSizeExceedsCapacityDoesNotUpdateRemovesOldEntryAndTriggersCompaction [FAIL]
      Assert.True() Failure
      Expected: True
      Actual:   False
      Stack Trace:
        /_/src/libraries/Microsoft.Extensions.Caching.Memory/tests/CapacityTests.cs(264,0): at Microsoft.Extensions.Caching.Memory.CapacityTests.AddingReplacementWhenTotalSizeExceedsCapacityDoesNotUpdateRemovesOldEntryAndTriggersCompaction()
        --- End of stack trace from previous location ---
  Finished:    Microsoft.Extensions.Caching.Memory.Tests
@radical radical added blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' area-Extensions-Caching test-failure labels Jul 27, 2022
@ghost ghost added the untriaged New issue has not been triaged by the area owner label Jul 27, 2022
@ghost
Copy link

ghost commented Jul 27, 2022

Tagging subscribers to this area: @dotnet/area-extensions-caching
See info in area-owners.md if you want to be subscribed.

Issue Details

Hit with Libraries Test Run release coreclr windows x86 Release on #72892 .
build, and log:

  Starting:    Microsoft.Extensions.Caching.Memory.Tests (parallel test collections = on, max threads = 2)
    Microsoft.Extensions.Caching.Memory.CapacityTests.AddingReplacementWhenTotalSizeExceedsCapacityDoesNotUpdateRemovesOldEntryAndTriggersCompaction [FAIL]
      Assert.True() Failure
      Expected: True
      Actual:   False
      Stack Trace:
        /_/src/libraries/Microsoft.Extensions.Caching.Memory/tests/CapacityTests.cs(264,0): at Microsoft.Extensions.Caching.Memory.CapacityTests.AddingReplacementWhenTotalSizeExceedsCapacityDoesNotUpdateRemovesOldEntryAndTriggersCompaction()
        --- End of stack trace from previous location ---
  Finished:    Microsoft.Extensions.Caching.Memory.Tests
Author: radical
Assignees: -
Labels:

blocking-clean-ci, area-Extensions-Caching, test-failure

Milestone: -

@eerhardt
Copy link
Member

cc @danmoseley

@danmoseley
Copy link
Member

failing here

            // Wait for compaction to complete
            Assert.True(await sem.WaitAsync(TimeSpan.FromSeconds(10)));

I'll run locally and see how long it normally takes to get an idea of whether it's hung or just taking eg 11 seconds.

@danmoseley
Copy link
Member

On my machine, the wait is < 1 millisecond so very likely increasing the wait won't help, and there is a bug eg EvictionCallback isn't getting called for some reason.

I'll disable the tests that wait for compaction.

@danmoseley danmoseley removed the blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' label Jul 28, 2022
@eerhardt eerhardt added the disabled-test The test is disabled in source code against the issue label Aug 1, 2022
@eerhardt eerhardt added this to the Future milestone Aug 1, 2022
@ghost ghost removed the untriaged New issue has not been triaged by the area owner label Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-Extensions-Caching disabled-test The test is disabled in source code against the issue test-failure
Projects
None yet
Development

No branches or pull requests

3 participants