Fix the NJulianRuleTest when running with libc check builds

[tarekgh]

Fixes #72825

NJulianRuleTest generates a time zone file at runtime to test with. The generated file works fine except if it is running with the checked libc library which causes the assert https://sources.debian.org/src/glibc/2.28-10/time/tzfile.c/#L440. The fix here is to update the tz file contents to avoid the assert and in same time will continue testing what we want test.

[dotnet-issue-labeler]

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

[tarekgh]

/azp run runtime-coreclr libraries-jitstressregs

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[tarekgh]

CC @danmoseley @VincentBu @eerhardt

[tarekgh]

@dotnet/dnceng QQ, I have enabled the pipeline runtime-coreclr libraries-jitstressregs in the comment #72893 (comment) but I am not seeing it in the list of the running legs. Any idea what I am missing?

[danmoseley]

I did examine which bytes are different, but ultimately -- seems reasonable if it's accepted by the parser..

[tarekgh]

/azp run runtime-coreclr jitstress-isas-arm

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[danmoseley]

@jakobbotsch is this requesting the right jit stress flavor to verify the fix?

[tarekgh]

Thanks @danmoseley for asking. According the failure https://dev.azure.com/dnceng/public/_build/results?buildId=1902209&view=ms.vss-test-web.build-test-results-tab&runId=49481618&paneView=debug&resultId=186492 the right pipeline should be runtime-coreclr libraries-jitstressregs. But I have tried to enable it in #72893 (comment) but I did not see this pipeline in the legs list even though the bot confirmed running it. So far, all enabled tests passed the test I am fixing. Will wait @jakobbotsch confirmation before I merge it.

[tarekgh]

/azp run runtime-coreclr jitstress

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[jakobbotsch]

Just a note: jitstress does not use a special build of the runtime, rather it uses a normal checked build and just passes some environment variables that makes the JIT behave slightly different.

The reason the rolling runtime pipeline runs are not failing is that they run libraries tests for linux-arm32 only with musl libc. Since this is a problem in glibc we don't see the error there.

It might be that libraries-jitstress and libraries-jitstressregs are the only two pipelines that end up running libraries tests with a checked coreclr build for linux-arm32 with glibc. libraries-jitstress is a good pipeline to trigger here to verify the fix.

[jakobbotsch]

/azp run runtime-coreclr libraries-jitstress

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[jakobbotsch]

FWIW, libraries-jitstressregs was fine to run too, I'm not sure why it did not trigger from your request above. The run I triggered above for libraries-jitstress does seem to be running: https://dev.azure.com/dnceng/public/_build/results?buildId=1906224&view=results

I've opened #72926 for the jitstress-isas-arm failure.

[dkurepa]

Hello, does this still need investigating, from what I understood, the runtime-coreclr libraries-jitstressregs was not needed in the end

[jakobbotsch]

Hello, does this still need investigating, from what I understood, the runtime-coreclr libraries-jitstressregs was not needed in the end

The confusion was why the pipeline did not trigger even though it was requested above. The bot replied with "Azure Pipelines successfully started running 1 pipeline(s)." yet there is no triggered run on https://dev.azure.com/dnceng/public/_build?definitionId=668&_a=summary

[jakobbotsch]

Looks like this does fix #72825. The failures looks unrelated (#72879, #71962, #72926, #72912).