Assertion failed 'retVal->OperIs(GT_LCL_VAR)' during 'Lowering nodeinfo'

[jakobbotsch]

Hit in recent jitstress-isas-arm run.
Pipeline run: https://dev.azure.com/dnceng/public/_build/results?buildId=1905701&view=results
Test failure: https://dev.azure.com/dnceng/public/_build/results?buildId=1905701&view=ms.vss-test-web.build-test-results-tab&runId=49527848&resultId=109615&paneView=debug
Console log: https://helixre107v0xdeko0k025g8.blob.core.windows.net/dotnet-runtime-refs-pull-72893-merge-0992787cb8a6487f81/JIT.Directed/1/console.03ebb829.log?helixlogtype=result

    JIT/Directed/StructABI/structreturn/structreturn.sh [FAIL]
      
      Assert failure(PID 2630 [0x00000a46], Thread: 2630 [0x0a46]): Assertion failed 'retVal->OperIs(GT_LCL_VAR)' in 'TestHFAandHVA:ReturnVector64Double():System.Runtime.Intrinsics.Vector64`1[Double]' during 'Lowering nodeinfo' (IL size 15; hash 0xdb77c6ef; FullOpts)
      
          File: /__w/1/s/src/coreclr/jit/lower.cpp Line: 3605
          Image: /root/helix/work/correlation/corerun

[ghost]

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Hit in recent jitstress-isas-arm run.
Pipeline run: https://dev.azure.com/dnceng/public/_build/results?buildId=1905701&view=results
Test failure: https://dev.azure.com/dnceng/public/_build/results?buildId=1905701&view=ms.vss-test-web.build-test-results-tab&runId=49527848&resultId=109615&paneView=debug
Console log: https://helixre107v0xdeko0k025g8.blob.core.windows.net/dotnet-runtime-refs-pull-72893-merge-0992787cb8a6487f81/JIT.Directed/1/console.03ebb829.log?helixlogtype=result

    JIT/Directed/StructABI/structreturn/structreturn.sh [FAIL]
      
      Assert failure(PID 2630 [0x00000a46], Thread: 2630 [0x0a46]): Assertion failed 'retVal->OperIs(GT_LCL_VAR)' in 'TestHFAandHVA:ReturnVector64Double():System.Runtime.Intrinsics.Vector64`1[Double]' during 'Lowering nodeinfo' (IL size 15; hash 0xdb77c6ef; FullOpts)
      
          File: /__w/1/s/src/coreclr/jit/lower.cpp Line: 3605
          Image: /root/helix/work/correlation/corerun

Author:	jakobbotsch
Assignees:	-
Labels:	area-CodeGen-coreclr
Milestone:	-

[jakobbotsch]

Introduced/exposed by fb1d318, cc @EgorBo

[EgorBo]

Hard to say how a x86 only change affected arm here

[jakobbotsch]

Hard to say how a x86 only change affected arm here

Maybe it's the managed changes? Or maybe I messed up the bisection.

[SingleAccretion]

Simple reproduction:

private static Vector64<double> Problem()
{
    var value = 0l;
    return Unsafe.As<long, Vector64<double>>(ref value);
}

Testing a fix right now.