Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MT][browser] SimultaneousStopBreakTests fails #91579

Closed
ilonatommy opened this issue Sep 5, 2023 · 1 comment · Fixed by #97505
Closed

[MT][browser] SimultaneousStopBreakTests fails #91579

ilonatommy opened this issue Sep 5, 2023 · 1 comment · Fixed by #97505
Assignees
@radekdoulik
Labels
arch-wasm WebAssembly architecture area-VM-threading-mono disabled-test The test is disabled in source code against the issue
Milestone
9.0.0

Comments

@ilonatommy
Copy link
Member

Failing after enabling all MT library tests (#91536).

[FAIL] System.Threading.Tasks.Tests.ParallelLoopResultTests.SimultaneousStopBreakTests
 System.InvalidOperationException : Break was called after Stop was called.
    at System.Threading.Tasks.ParallelLoopState.Break[Int32](Int32 iteration, ParallelLoopStateFlags`1 pflags)
    at System.Threading.Tasks.ParallelLoopState`1[[System.Int32, System.Private.CoreLib, Version=9.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]].InternalBreak()
    at System.Threading.Tasks.ParallelLoopState.Break()
    at System.Threading.Tasks.Tests.ParallelLoopResultTests.<>c.<SimultaneousStopBreakTests>b__14_0(Int32 i, ParallelLoopState ps)
    at System.Threading.Tasks.Parallel.<>c__DisplayClass19_0`2[[System.Object, System.Private.CoreLib, Version=9.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e],[System.Int32, System.Private.CoreLib, Version=9.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]].<ForWorker>b__1(RangeWorker& currentWorker, Int64 timeout, Boolean& replicationDelegateYieldedBeforeCompletion)
 --- End of stack trace from previous location ---
    at System.Threading.Tasks.Parallel.<>c__DisplayClass19_0`2[[System.Object, System.Private.CoreLib, Version=9.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e],[System.Int32, System.Private.CoreLib, Version=9.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]].<ForWorker>b__1(RangeWorker& currentWorker, Int64 timeout, Boolean& replicationDelegateYieldedBeforeCompletion)
    at System.Threading.Tasks.TaskReplicator.Run[RangeWorker](ReplicatableUserAction`1 action, ParallelOptions options, Boolean stopOnFirstFailure)
    at System.Threading.Tasks.Parallel.ForWorker[Object,Int32](Int32 fromInclusive, Int32 toExclusive, ParallelOptions parallelOptions, Action`1 body, Action`2 bodyWithState, Func`4 bodyWithLocal, Func`1 localInit, Action`1 localFinally)
    at System.Threading.Tasks.Parallel.For(Int32 fromInclusive, Int32 toExclusive, ParallelOptions parallelOptions, Action`2 body)
    at System.Threading.Tasks.Tests.ParallelLoopResultTests.ForPLRTest(Action`2 body, ParallelOptions parallelOptions, String desc, Boolean excExpected, Boolean shouldComplete, Boolean shouldStop, Boolean shouldBreak, Boolean shouldCancel)
    at System.Threading.Tasks.Tests.ParallelLoopResultTests.ForPLRTest(Action`2 body, String desc, Boolean excExpected, Boolean shouldComplete, Boolean shouldStop, Boolean shouldBreak)
    at System.Threading.Tasks.Tests.ParallelLoopResultTests.SimultaneousStopBreakTests()
    at System.Reflection.MethodBaseInvoker.InterpretedInvoke_Method(Object obj, IntPtr* args)
    at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr)
@ilonatommy ilonatommy added arch-wasm WebAssembly architecture disabled-test The test is disabled in source code against the issue area-Build-mono area-VM-threading-mono labels Sep 5, 2023
@ghost ghost added the untriaged New issue has not been triaged by the area owner label Sep 5, 2023
@ghost
Copy link

ghost commented Sep 5, 2023

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Failing after enabling all MT library tests (#91536).

[FAIL] System.Threading.Tasks.Tests.ParallelLoopResultTests.SimultaneousStopBreakTests
 System.InvalidOperationException : Break was called after Stop was called.
    at System.Threading.Tasks.ParallelLoopState.Break[Int32](Int32 iteration, ParallelLoopStateFlags`1 pflags)
    at System.Threading.Tasks.ParallelLoopState`1[[System.Int32, System.Private.CoreLib, Version=9.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]].InternalBreak()
    at System.Threading.Tasks.ParallelLoopState.Break()
    at System.Threading.Tasks.Tests.ParallelLoopResultTests.<>c.<SimultaneousStopBreakTests>b__14_0(Int32 i, ParallelLoopState ps)
    at System.Threading.Tasks.Parallel.<>c__DisplayClass19_0`2[[System.Object, System.Private.CoreLib, Version=9.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e],[System.Int32, System.Private.CoreLib, Version=9.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]].<ForWorker>b__1(RangeWorker& currentWorker, Int64 timeout, Boolean& replicationDelegateYieldedBeforeCompletion)
 --- End of stack trace from previous location ---
    at System.Threading.Tasks.Parallel.<>c__DisplayClass19_0`2[[System.Object, System.Private.CoreLib, Version=9.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e],[System.Int32, System.Private.CoreLib, Version=9.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]].<ForWorker>b__1(RangeWorker& currentWorker, Int64 timeout, Boolean& replicationDelegateYieldedBeforeCompletion)
    at System.Threading.Tasks.TaskReplicator.Run[RangeWorker](ReplicatableUserAction`1 action, ParallelOptions options, Boolean stopOnFirstFailure)
    at System.Threading.Tasks.Parallel.ForWorker[Object,Int32](Int32 fromInclusive, Int32 toExclusive, ParallelOptions parallelOptions, Action`1 body, Action`2 bodyWithState, Func`4 bodyWithLocal, Func`1 localInit, Action`1 localFinally)
    at System.Threading.Tasks.Parallel.For(Int32 fromInclusive, Int32 toExclusive, ParallelOptions parallelOptions, Action`2 body)
    at System.Threading.Tasks.Tests.ParallelLoopResultTests.ForPLRTest(Action`2 body, ParallelOptions parallelOptions, String desc, Boolean excExpected, Boolean shouldComplete, Boolean shouldStop, Boolean shouldBreak, Boolean shouldCancel)
    at System.Threading.Tasks.Tests.ParallelLoopResultTests.ForPLRTest(Action`2 body, String desc, Boolean excExpected, Boolean shouldComplete, Boolean shouldStop, Boolean shouldBreak)
    at System.Threading.Tasks.Tests.ParallelLoopResultTests.SimultaneousStopBreakTests()
    at System.Reflection.MethodBaseInvoker.InterpretedInvoke_Method(Object obj, IntPtr* args)
    at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr)
Author: ilonatommy
Assignees: -
Labels:

arch-wasm, disabled-test, area-Build-mono, area-VM-threading-mono
Milestone: -

@radical radical added this to the 9.0.0 milestone Sep 5, 2023
@ghost ghost removed the untriaged New issue has not been triaged by the area owner label Sep 5, 2023
pavelsavara added a commit to pavelsavara/runtime that referenced this issue Nov 3, 2023
@pavelsavara
keep ActiveIssue dotnet#91579
250d986
lewing pushed a commit that referenced this issue Nov 6, 2023
@pavelsavara
[browser][MT] enable MT PLINQ (#94214)
c4d5505 
* wip

* keep ActiveIssue #91579

* more

* more

* more

* more

* feedback
@pavelsavara pavelsavara self-assigned this Nov 8, 2023
@pavelsavara pavelsavara mentioned this issue Nov 9, 2023
Closed
31 tasks
radekdoulik added a commit to radekdoulik/runtime that referenced this issue Jan 25, 2024
@radekdoulik
[wasm][mt] Fix System.Threading.Tasks.Parallel build
5644f37 
Fixes dotnet#91583 and dotnet#91579
@radekdoulik radekdoulik mentioned this issue Jan 25, 2024
Merged
@lewing lewing assigned radekdoulik and unassigned pavelsavara Jan 25, 2024
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Jan 25, 2024
radekdoulik added a commit that referenced this issue Jan 26, 2024
@radekdoulik
[wasm][mt] Fix System.Threading.Tasks.Parallel build (#97505)
c105e7d 
* [wasm][mt] Fix System.Threading.Tasks.Parallel build

Fixes #91583 and #91579

* Enable 5 more tests

* Feedback

* Fix typo
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Jan 26, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Feb 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@radekdoulik radekdoulik

Labels
arch-wasm WebAssembly architecture area-VM-threading-mono disabled-test The test is disabled in source code against the issue
Projects
None yet
Milestone
9.0.0
Development

Successfully merging a pull request may close this issue.

[wasm][mt] Fix System.Threading.Tasks.Parallel build radekdoulik/runtime
4 participants
@radical @pavelsavara @radekdoulik @ilonatommy