Build error NETSDK1124 with NET8 RC2 when multiple TargetFrameworks #94406

snakefoot · 2023-10-28T14:58:52Z

Description

Trying to publish an application <TargetFramework>net8.0</TargetFramework> with trimming enabled:

dotnet publish -r win-x64 -c release --self-contained -p:PublishTrimmed=true .\examples\NetCore2\HostingExample

The application depends on two libraries:

NLog.Extensions.Logging:

<TargetFrameworks>net461;netstandard1.3;netstandard1.5;netstandard2.0;netstandard2.1;net6.0;net8.0</TargetFrameworks>

NLog.Extensions.Hosting:

<TargetFrameworks>netstandard2.0;netstandard2.1;net6.0;net8.0</TargetFrameworks>

The build fails with the following error:

C:\Program Files\dotnet\sdk\8.0.100-rc.2.23502.2\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Sdk.FrameworkReferenceRes
olution.targets(90,5): error NETSDK1124: Trimming assemblies requires .NET Core 3.0 or higher. [C:\Users\snakefoot\sour
ce\repos\NLog.Extensions.Logging\src\NLog.Extensions.Hosting\NLog.Extensions.Hosting.csproj::TargetFramework=netstandar
d2.0]
C:\Program Files\dotnet\sdk\8.0.100-rc.2.23502.2\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Sdk.FrameworkReferenceRes
olution.targets(90,5): error NETSDK1124: Trimming assemblies requires .NET Core 3.0 or higher. [C:\Users\snakefoot\sour
ce\repos\NLog.Extensions.Logging\src\NLog.Extensions.Logging\NLog.Extensions.Logging.csproj::TargetFramework=net461]

Reproduction Steps

Publish NET8 application with trimming, that depends on projects with mutiple <TargetFrameworks> (Besides NET8)

Also tried to update library-projects to be very explicit about when to enable trimming, but build with publish still fails (No warnings or errors with standard dotnet build):

    <EnableTrimAnalyzer Condition=" '$(TargetFramework)' == 'net8.0'">true</EnableTrimAnalyzer>
    <IsTrimmable Condition=" '$(TargetFramework)' == 'net8.0'">true</IsTrimmable>

Also tried adding these command-line options -f net8.0 or -p:TargetFramework=net8.0, but the build-error remains.

Expected behavior

Build publishes the application without errors.

Actual behavior

Build fails with error NETSDK1124: Trimming assemblies requires .NET Core 3.0 or higher. for the library projects.

Regression?

Build publish with trimming works fine with NET6 + NET7

Known Workarounds

Uninstall NET8 RC2 SDK or stop using multiple TargetFrameworks in library-projects or depend on nuget-packages instead of the library-projects directly.

Configuration

No response

Other information

No response

The text was updated successfully, but these errors were encountered:

ghost · 2023-10-28T14:59:02Z

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

Issue Details

Description

Trying to publish an application <TargetFramework>net8.0</TargetFramework> with trimming enabled:

dotnet publish -r win-x64 -c release --self-contained -p:PublishTrimmed=true .\examples\NetCore2\HostingExample

The application depends on two libraries:

NLog.Extensions.Logging:

<TargetFrameworks>net461;netstandard1.3;netstandard1.5;netstandard2.0;netstandard2.1;net6.0;net8.0</TargetFrameworks>

NLog.Extensions.Hosting:

<TargetFrameworks>netstandard2.0;netstandard2.1;net6.0;net8.0</TargetFrameworks>

The build fails with the following error:

C:\Program Files\dotnet\sdk\8.0.100-rc.2.23502.2\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Sdk.FrameworkReferenceRes
olution.targets(90,5): error NETSDK1124: Trimming assemblies requires .NET Core 3.0 or higher. [C:\Users\snakefoot\sour
ce\repos\NLog.Extensions.Logging\src\NLog.Extensions.Hosting\NLog.Extensions.Hosting.csproj::TargetFramework=netstandar
d2.0]
C:\Program Files\dotnet\sdk\8.0.100-rc.2.23502.2\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Sdk.FrameworkReferenceRes
olution.targets(90,5): error NETSDK1124: Trimming assemblies requires .NET Core 3.0 or higher. [C:\Users\snakefoot\sour
ce\repos\NLog.Extensions.Logging\src\NLog.Extensions.Logging\NLog.Extensions.Logging.csproj::TargetFramework=net461]

Reproduction Steps

Publish NET8 application with trimming, that depends on projects with mutiple <TargetFrameworks> (Besides NET8)

Expected behavior

Build publishes the application without errors.

Actual behavior

Build fails with error NETSDK1124: Trimming assemblies requires .NET Core 3.0 or higher. for the library projects.

Regression?

Build works fine with NET6 + NET7

Known Workarounds

Uninstall NET8 RC2 SDK

Configuration

No response

Other information

No response

Author:	snakefoot
Assignees:	-
Labels:	`area-Infrastructure-libraries`, `untriaged`
Milestone:	-

snakefoot · 2023-10-29T12:07:37Z

@ViktorHofer Curious why this is moved to dotnet/sdk, since #91535 + #91542 was handled in dotnet/runtime ? Or was it just a fix to dotnet/runtime to work-around the issue in dotnet/sdk ?

snakefoot · 2023-10-29T12:29:00Z

Was able to publish without build-errors by adding -p:TargetFrameworks=net8.0 (And ensure all libraries supported net8.0):

dotnet publish -p:TargetFrameworks=net8.0 -r win-x64 -c release --self-contained -p:PublishTrimmed=true .\examples\NetCore2\HostingExample

snakefoot · 2023-10-29T12:34:46Z

Hrm adding -p:TargetFrameworks=net8.0 apparently disables --self-contained, and final optimizing is not performed.

ghost · 2023-11-06T12:14:44Z

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

Issue Details

Description

Trying to publish an application <TargetFramework>net8.0</TargetFramework> with trimming enabled:

dotnet publish -r win-x64 -c release --self-contained -p:PublishTrimmed=true .\examples\NetCore2\HostingExample

The application depends on two libraries:

NLog.Extensions.Logging:

<TargetFrameworks>net461;netstandard1.3;netstandard1.5;netstandard2.0;netstandard2.1;net6.0;net8.0</TargetFrameworks>

NLog.Extensions.Hosting:

<TargetFrameworks>netstandard2.0;netstandard2.1;net6.0;net8.0</TargetFrameworks>

The build fails with the following error:

C:\Program Files\dotnet\sdk\8.0.100-rc.2.23502.2\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Sdk.FrameworkReferenceRes
olution.targets(90,5): error NETSDK1124: Trimming assemblies requires .NET Core 3.0 or higher. [C:\Users\snakefoot\sour
ce\repos\NLog.Extensions.Logging\src\NLog.Extensions.Hosting\NLog.Extensions.Hosting.csproj::TargetFramework=netstandar
d2.0]
C:\Program Files\dotnet\sdk\8.0.100-rc.2.23502.2\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Sdk.FrameworkReferenceRes
olution.targets(90,5): error NETSDK1124: Trimming assemblies requires .NET Core 3.0 or higher. [C:\Users\snakefoot\sour
ce\repos\NLog.Extensions.Logging\src\NLog.Extensions.Logging\NLog.Extensions.Logging.csproj::TargetFramework=net461]

Reproduction Steps

Publish NET8 application with trimming, that depends on projects with mutiple <TargetFrameworks> (Besides NET8)

Also tried to update library-projects to be very explicit about when to enable trimming, but build with publish still fails (No warnings or errors with standard dotnet build):

    <EnableTrimAnalyzer Condition=" '$(TargetFramework)' == 'net8.0'">true</EnableTrimAnalyzer>
    <IsTrimmable Condition=" '$(TargetFramework)' == 'net8.0'">true</IsTrimmable>

Also tried adding these command-line options -f net8.0 or -p:TargetFramework=net8.0, but the build-error remains.

Expected behavior

Build publishes the application without errors.

Actual behavior

Build fails with error NETSDK1124: Trimming assemblies requires .NET Core 3.0 or higher. for the library projects.

Regression?

Build publish with trimming works fine with NET6 + NET7

Known Workarounds

Uninstall NET8 RC2 SDK or stop using multiple TargetFrameworks in library-projects or depend on nuget-packages instead of the library-projects directly.

Configuration

No response

Other information

No response

Author:	snakefoot
Assignees:	-
Labels:	`area-Infrastructure-libraries`, `untriaged`
Milestone:	-

ViktorHofer · 2023-11-06T12:35:29Z

Good point. I just moved the issue back. cc @agocke

ChaosEngine · 2023-11-07T20:59:29Z

I am seeing similiar error on
dotnet publish --no-restore -c Release --self-contained -r linux-x64 -p:PublishTrimmed=true Project
when including <TargetFramework>netstandard2.0</TargetFramework> library as dependency of main
<TargetFramework>net8.0</TargetFramework build

ViktorHofer · 2023-11-07T21:13:53Z

cc @vitek-karas

vitek-karas · 2023-11-08T18:56:34Z

@snakefoot, could you please try adding <PublishTrimmed>true</PublishTrimmed> to your project file for the app and remove it from the command line?

There is a somewhat unexpected MSBuild behavior where all properties passed on the command line are forced onto all projects (even dependencies), and PublishTrimmed will turn on EnableTrimAnalyzers which will cause the error on projects targeting just netstandard2.0 (for a good reason). This behavior makes littles sense for property like PublishTrimmed, but MSBuild currently does it for everything.

/cc @sbomer

snakefoot · 2023-11-08T19:09:48Z

Yes moving <PublishTrimmed>true</PublishTrimmed> into the application csproj-file (and removing from the command-line) resolved the publish error for me.

Combined with adding <IsTrimmable Condition="'$(TargetFramework)' == 'net8.0'">true</IsTrimmable> to the other library-projects.

ChaosEngine · 2023-11-09T13:24:43Z

@snakefoot, could you please try adding <PublishTrimmed>true</PublishTrimmed> to your project file for the app and remove it from the command line?

There is a somewhat unexpected MSBuild behavior where all properties passed on the command line are forced onto all projects (even dependencies), and PublishTrimmed will turn on EnableTrimAnalyzers which will cause the error on projects targeting just netstandard2.0 (for a good reason). This behavior makes littles sense for property like PublishTrimmed, but MSBuild currently does it for everything.

/cc @sbomer

My problem is also resolved for two Docker builds (alpine and debian based) with trimming enabled - now only in top-most *.csproj I am having <PublishTrimmed>true</PublishTrimmed>

vitek-karas · 2023-11-10T15:53:56Z

Our guidance is to put the PublishTrimmed (or PublishAot) properties into the project file. Not only it doesn't have this particular problem but it will also:

enable analyzers for your app's project so that you get trim/AOT related warnings during build
modifies some settings such that the app will behave the same in debug builds as well as when published trimmed (trimming by default disables some runtime functionality which is not compatible with trimming for example)
this means that you should gain confidence in the behavior of the app after publish, and you can test with the same runtime behavior it will have after trimming.

@sbomer - can we raise this again with the SDK/MSBuild people, to see if we can make progress on it? Originally it was just a quirk we found internally, but this indicates people are running into it.

sbomer · 2023-11-10T18:27:36Z

I'll check with MSBuild folks again. Last time we asked, there were two possible fixes:

Special-casing the publish properties in MSBuild at https://github.com/dotnet/msbuild/blob/74f7ebbb3dd2817dede9621a00ccb343c638be2d/src/Tasks/Microsoft.Common.CurrentVersion.targets#L807
Prevent PublishTrimmed from influencing restore when IsPublishable=false (default for library projects).

I think both of those solutions are worse than the original problem. It sounds like moving PublishTrimmed to the project file was an acceptable solution so far, so I don't think we should go out of our way to make it easier to pass PublishTrimmed on the command-line unless it becomes a blocker for people, or we have a better fix on the MSBuild side.

snakefoot · 2023-11-11T14:48:39Z

I think the current build-error message is a little confusing:

NETSDK1124 | Trimming assemblies requires .NET Core 3.0 or higher.

When the solution involves removing PublishTrimmed from command-line and instead specifying it in app-csproj-file, and also making sure IsTrimmable is conditional.

vitek-karas · 2023-11-11T15:28:43Z

The problem is that the error was never meant to be triggered by PublishTrimmed, it's there if you add IsTrimmable onto a netstandard2.0 project. But the flow of the various properties causes it to show up anyway. I guess we could detect that PublishTrimmed is set and show a different error possibly.

Related to dotnet/sdk#37228 + dotnet/runtime#94406

agocke · 2024-04-22T16:51:06Z

Another way to easily handle this in the project file is to use a condition:

  <PropertyGroup Condition="$([MSBuild]::IsTargetFrameworkCompatible('$(TargetFramework)', 'net7.0'))">
    <PublishTrimmed>true</PublishTrimmed>
  </PropertyGroup>

ghost added the untriaged New issue has not been triaged by the area owner label Oct 28, 2023

ViktorHofer transferred this issue from dotnet/runtime Oct 28, 2023

snakefoot closed this as completed Oct 29, 2023

snakefoot reopened this Oct 29, 2023

dotnet-issue-labeler bot added the area-Infrastructure-libraries label Nov 6, 2023

ViktorHofer transferred this issue from dotnet/sdk Nov 6, 2023

ViktorHofer added area-Tools-ILLink .NET linker development as well as trimming analyzers and removed area-Infrastructure-libraries labels Nov 6, 2023

rainersigwald mentioned this issue Nov 10, 2023

Consider removing PublishTrimmed from p2p refs dotnet/msbuild#9415

Open

vitek-karas mentioned this issue Nov 29, 2023

AOT compile gives incorrect error about Roslyn source generator coming from a ProjectReference dotnet/sdk#37228

Open

twsouthwick mentioned this issue Dec 8, 2023

Enable AOT builds again with .NET 8 toolchain dotnet/Open-XML-SDK#1578

Open

hwoodiwiss added a commit to hwoodiwiss/ArgumentativeFilters that referenced this issue Dec 23, 2023

Rely on publish AoT in the csproj

093dab3

Related to dotnet/sdk#37228 + dotnet/runtime#94406

agocke closed this as completed Apr 22, 2024

dotnet-policy-service bot removed the untriaged New issue has not been triaged by the area owner label Apr 22, 2024

github-actions bot locked and limited conversation to collaborators May 23, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Build error NETSDK1124 with NET8 RC2 when multiple TargetFrameworks #94406

Build error NETSDK1124 with NET8 RC2 when multiple TargetFrameworks #94406

snakefoot commented Oct 28, 2023 •

edited

Loading

ghost commented Oct 28, 2023

Description

Reproduction Steps

Expected behavior

Actual behavior

Regression?

Known Workarounds

Configuration

Other information

snakefoot commented Oct 29, 2023 •

edited

Loading

snakefoot commented Oct 29, 2023 •

edited

Loading

snakefoot commented Oct 29, 2023 •

edited

Loading

ghost commented Nov 6, 2023

Description

Reproduction Steps

Expected behavior

Actual behavior

Regression?

Known Workarounds

Configuration

Other information

ViktorHofer commented Nov 6, 2023

ChaosEngine commented Nov 7, 2023 •

edited

Loading

ViktorHofer commented Nov 7, 2023

vitek-karas commented Nov 8, 2023

snakefoot commented Nov 8, 2023 •

edited

Loading

ChaosEngine commented Nov 9, 2023 •

edited

Loading

vitek-karas commented Nov 10, 2023

sbomer commented Nov 10, 2023

snakefoot commented Nov 11, 2023

vitek-karas commented Nov 11, 2023

agocke commented Apr 22, 2024

Build error NETSDK1124 with NET8 RC2 when multiple TargetFrameworks #94406

Build error NETSDK1124 with NET8 RC2 when multiple TargetFrameworks #94406

Comments

snakefoot commented Oct 28, 2023 • edited Loading

Description

Reproduction Steps

Expected behavior

Actual behavior

Regression?

Known Workarounds

Configuration

Other information

ghost commented Oct 28, 2023

Description

Reproduction Steps

Expected behavior

Actual behavior

Regression?

Known Workarounds

Configuration

Other information

snakefoot commented Oct 29, 2023 • edited Loading

snakefoot commented Oct 29, 2023 • edited Loading

snakefoot commented Oct 29, 2023 • edited Loading

ghost commented Nov 6, 2023

Description

Reproduction Steps

Expected behavior

Actual behavior

Regression?

Known Workarounds

Configuration

Other information

ViktorHofer commented Nov 6, 2023

ChaosEngine commented Nov 7, 2023 • edited Loading

ViktorHofer commented Nov 7, 2023

vitek-karas commented Nov 8, 2023

snakefoot commented Nov 8, 2023 • edited Loading

ChaosEngine commented Nov 9, 2023 • edited Loading

vitek-karas commented Nov 10, 2023

sbomer commented Nov 10, 2023

snakefoot commented Nov 11, 2023

vitek-karas commented Nov 11, 2023

agocke commented Apr 22, 2024

snakefoot commented Oct 28, 2023 •

edited

Loading

snakefoot commented Oct 29, 2023 •

edited

Loading

snakefoot commented Oct 29, 2023 •

edited

Loading

snakefoot commented Oct 29, 2023 •

edited

Loading

ChaosEngine commented Nov 7, 2023 •

edited

Loading

snakefoot commented Nov 8, 2023 •

edited

Loading

ChaosEngine commented Nov 9, 2023 •

edited

Loading