Avoid 0-length array allocation for empty Distinct/Union.ToArray #100218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also makes Enumerable.ToArray more inlineable and removes a bit of duplicated code.
|
Tagging subscribers to this area: @dotnet/area-system-linq |
This was referenced Mar 25, 2024
| } | ||
|
|
||
| return EnumerableToArray(source); | ||
|
|
||
| [MethodImpl(MethodImplOptions.NoInlining)] // avoid large stack allocation impacting other paths | ||
| static TSource[] EnumerableToArray(IEnumerable<TSource> source) | ||
| { | ||
| if (source is null) |
There was a problem hiding this comment.
Nit: nesting validation inside the local method will result in its compiler-generated name to show up in the stack trace. I would prefer it if validation was done separately on each public method even if that results in duplication.
eiriktsarpalis
approved these changes
Mar 25, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also makes Enumerable.ToArray more inlineable and removes a bit of duplicated code.