Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove preventing EH and entering EE at shutdown #100293

Merged
merged 4 commits into from
Mar 27, 2024

Commits on Mar 26, 2024

  1. Remove preventing EH and entering EE at shutdown

    Historically, the runtime was trying to block handling exceptions,
    entering EE and other stuff during shutdown of the runtime. We have
    already removed most of that in the past, since it has been a deadlock
    farm. While debugging a customer issue, I have found that we are still
    preventing some things to happen during shutdown. We stop handling
    exceptions at all and we also prevent entering EE at few places.
    This change removes these, as the plan we've been on is to keep the
    runtime running until the OS itself stops the process.
    In the customer's case, the problem was that during a machine
    shutdown, .NET runtime was generating watson dump due to an unhandled
    exception stemming from a network socket related code that would otherwise
    be handled.
    janvorli committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    1615141 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e45343a View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    6c0033c View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    fabd3cd View commit details
    Browse the repository at this point in the history