Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix more diagnostics with CA2263 #100490

Merged
merged 2 commits into from
Apr 2, 2024
Merged

Fix more diagnostics with CA2263 #100490

merged 2 commits into from
Apr 2, 2024

Conversation

buyaa-n
Copy link
Member

@buyaa-n buyaa-n commented Apr 1, 2024

Fix more diagnostics found with CA2263: Prefer generic overload when type is known

Excluded fixing diagnostics for

  • Projects that build on lower versions like netstandard
  • Excluded findings in Test projects like Microsoft.Extensions.DependencyInjection.Specification.Tests
  • Excluded diagnostics on Linq.Expressions

Related to #99343 (comment)

Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-meta
See info in area-owners.md if you want to be subscribed.

Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a lot of interop cleanup and simplification that can be done in the legacy components. I have commented on some of it (it may require annotating method as unsafe).

Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@buyaa-n buyaa-n merged commit 1ec64a7 into dotnet:main Apr 2, 2024
156 of 160 checks passed
@buyaa-n buyaa-n deleted the fix-diagnostics branch April 2, 2024 18:07
jakobbotsch pushed a commit to jakobbotsch/runtime that referenced this pull request Apr 3, 2024
* Fix more diagnostics with CA2263

* Apply feedbacks
matouskozak pushed a commit to matouskozak/runtime that referenced this pull request Apr 30, 2024
* Fix more diagnostics with CA2263

* Apply feedbacks
@github-actions github-actions bot locked and limited conversation to collaborators May 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants