Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[browser][mt] Fix SignalRClientTests timeouts #100516

Closed
wants to merge 2 commits into from

Conversation

ilonatommy
Copy link
Member

@ilonatommy ilonatommy commented Apr 2, 2024

Fixes #100388 and fixes #100445. The tests are supposed to check signalR connection in MT runtime and the timeouts occur before any connection is even made (OnAfterRender is not triggered), so adding retries does not obscure the objective of the test.

@ilonatommy ilonatommy added arch-wasm WebAssembly architecture area-VM-threading-mono labels Apr 2, 2024
@ilonatommy ilonatommy self-assigned this Apr 2, 2024
Copy link
Contributor

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

@ilonatommy ilonatommy changed the title [wip] SignalRClientTests timeouts [browser][mt] Fix SignalRClientTests timeouts Apr 2, 2024
@ilonatommy ilonatommy marked this pull request as ready for review April 2, 2024 15:10
@ilonatommy ilonatommy requested a review from maraf as a code owner April 2, 2024 15:10
@ilonatommy
Copy link
Member Author

The test gets disabled in #100577 and we will create non-blazor signalR WBT.

@ilonatommy ilonatommy closed this Apr 3, 2024
@github-actions github-actions bot locked and limited conversation to collaborators May 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-VM-threading-mono
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[wasm] SignalR tests timing out [browser][mt] SignalRClientTests timeouts
1 participant