Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement RuntimeHelpers.Box #100561

Merged
merged 12 commits into from
Apr 6, 2024
Merged

Implement RuntimeHelpers.Box #100561

merged 12 commits into from
Apr 6, 2024

Conversation

jkoritzinsky
Copy link
Member

Fixes #97341

Implement RuntimeHelpers.Box with the same semantics as the box IL instruction. It creates a new box for value types, returns the existing object for reference types, and throws for byref types and pointers. It also throws a NullReferenceException when boxing a null by-ref (matching CoreCLR's existing behavior).

@dotnet-issue-labeler dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

This was referenced Apr 3, 2024
Closed
Open
This was referenced Apr 4, 2024
Open
Open
Closed
This was referenced Apr 4, 2024
Closed
Closed
@build-analysis build-analysis bot mentioned this pull request Apr 4, 2024
Open
@jkoritzinsky jkoritzinsky requested a review from jkotas April 5, 2024 17:16
jkotas
jkotas approved these changes Apr 5, 2024
View reviewed changes
Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

This was referenced Apr 6, 2024
Open
Closed
Closed
@jkoritzinsky jkoritzinsky merged commit 7c4fc07 into dotnet:main Apr 6, 2024
157 of 161 checks passed
@jkoritzinsky jkoritzinsky deleted the box branch April 6, 2024 03:17
matouskozak pushed a commit to matouskozak/runtime that referenced this pull request Apr 30, 2024
@jkoritzinsky @matouskozak
Implement RuntimeHelpers.Box (dotnet#100561)
dc62901
@build-analysis build-analysis bot mentioned this pull request May 2, 2024
Open
@github-actions github-actions bot locked and limited conversation to collaborators May 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MichalStrehovsky MichalStrehovsky MichalStrehovsky left review comments

@jkotas jkotas jkotas approved these changes

@lambdageek lambdageek Awaiting requested review from lambdageek lambdageek is a code owner

@thaystg thaystg Awaiting requested review from thaystg thaystg is a code owner

@marek-safar marek-safar Awaiting requested review from marek-safar marek-safar is a code owner

Assignees

@jkoritzinsky jkoritzinsky

Labels
area-System.Runtime new-api-needs-documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[API Proposal]: RuntimeHelpers.Box to create a box around a dynamically-typed byref
3 participants
@jkoritzinsky @jkotas @MichalStrehovsky