Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable frequently failing tests #101439

Merged
merged 2 commits into from
Apr 24, 2024
Merged

Conversation

Copy link
Member

@wfurt wfurt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

[SkipOnPlatform(TestPlatforms.Browser, "CookieContainer is not supported on Browser")]
public async Task GetAsync_SetCookieContainerAndCookieHeader_BothCookiesSent()
{
if (UseVersion == HttpVersion30)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will work as well, but what I've seen, we usually override the failing test in the H3 implementation class and put the ActiveIssue attribute on that.

@@ -71,9 +73,14 @@ fromVersion.Major switch
{ HttpVersion.Version20, false }
};

[Fact]
[ConditionalFact]
public async Task AltSvc_ConnectionFrame_UpgradeFrom20_Success()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this one is always about H/2 -> H/3 upgrade, so this should be just [ActiveIssue]

Copy link
Member

@CarnaViire CarnaViire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Let's merge it like this to reduce the noise, we can address Mana's and mine comments as a follow-up

@rzikm rzikm merged commit e01db17 into dotnet:main Apr 24, 2024
80 of 87 checks passed
@CarnaViire
Copy link
Member

As discussed offline, the problem might get fixed by the combination of the following PRs: #101447 and #101250
So we will postpone the follow-up until these 2 PRs are in, and after that I will check whether the issue is still there. I will proceed with the follow up and investigations only if the issue still persists.

liveans added a commit to liveans/dotnet-runtime that referenced this pull request Apr 26, 2024
matouskozak pushed a commit to matouskozak/runtime that referenced this pull request Apr 30, 2024
michaelgsharp pushed a commit to michaelgsharp/runtime that referenced this pull request May 9, 2024
@karelz karelz added this to the 9.0.0 milestone May 14, 2024
CarnaViire added a commit to CarnaViire/runtime that referenced this pull request May 28, 2024
Ruihan-Yin pushed a commit to Ruihan-Yin/runtime that referenced this pull request May 30, 2024
liveans added a commit to liveans/dotnet-runtime that referenced this pull request Jun 3, 2024
liveans added a commit that referenced this pull request Jun 4, 2024
…sabled http3 tests (#102996)

* Revert "Disable parallel test execution for QUIC and HTTP/3 (#101569)"

This reverts commit 009d74e.

* Revert "Disable frequently failing tests (#101439)"

This reverts commit e01db17.

* Delete whitespace

* Style changes
@github-actions github-actions bot locked and limited conversation to collaborators Jun 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants