Support using the system rapidjson to build #101443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-policy-service
bot
added
the
community-contribution
|
Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov |
This was referenced Apr 23, 2024
Closed
Closed
This was referenced May 1, 2024
elinor-fung
approved these changes
May 7, 2024
|
My driving motivation for using system libraries is described by https://fedoraproject.org/wiki/Bundled_Libraries. My current focus is to do this for all libraries under The current full list is also visible on #101797 |
This was referenced Jun 3, 2024
Open
|
@omajid Mind sorting out the conflict? |
We have a bundled copy of rapidjson in runtime, but some Linux distributions also ship with another version of that library. Support using that too, optionally. This does not change the default behaviour - the bundled copy of rapidjson is used. A cmake argument of CLR_CMAKE_USE_SYSTEM_RAPIDJSON=true needs to be set to use the system version of rapidjson.
|
@agocke Done. |
This was referenced Jul 3, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a bundled copy of rapidjson in runtime, but some Linux distributions also ship with another version of that library. Support using that too, optionally.
This does not change the default behaviour - the bundled copy of rapidjson is used. A cmake argument of
CLR_CMAKE_USE_SYSTEM_RAPIDJSON=true needs to be set to use the system version of rapidjson.