Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport #92375 and #93082 to release/8.0-staging #101744

Conversation

eduardo-vp
Copy link
Member

@eduardo-vp eduardo-vp commented Apr 30, 2024

This is part of the work to transition to the 1ES templates in servicing branches.

PR #92375 was cleanly cherry-picked, except for changes in eng/pipelines/coreclr/runtime-nativeaot-outerloop.yml which were discarded.

For PR #93082, only the changes in eng/pipelines/runtime*.yml were included as the others are not required.

Official build: https://dev.azure.com/dnceng/internal/_build/results?buildId=2442616&view=results

cc @jkoritzinsky @agocke @amanasifkhalid

@eduardo-vp eduardo-vp changed the base branch from main to release/8.0-staging April 30, 2024 21:58
@dotnet-issue-labeler dotnet-issue-labeler bot added needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners new-api-needs-documentation labels Apr 30, 2024
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@eduardo-vp eduardo-vp added area-Infrastructure and removed new-api-needs-documentation needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels May 1, 2024
Copy link
Contributor

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

@eduardo-vp eduardo-vp changed the title [Testing] Backport #92375 and #93082 to release/8.0-staging Backport #92375 and #93082 to release/8.0-staging May 1, 2024
@eduardo-vp eduardo-vp marked this pull request as ready for review May 1, 2024 05:09
@eduardo-vp eduardo-vp requested a review from radical as a code owner May 1, 2024 05:09
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably not strictly necessary to backport new tests, but not a problem if it makes porting easier. This won’t work for net6 because Native aot wasn’t supported then.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, thanks for letting me know. I'll make the PR simpler in that case, hoping that it can be directly backported to net6

Copy link
Member

@agocke agocke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm although we only strictly need to port changes to runtime-official and dependencies thereof. If possible I would try to avoid other changes that may change behavior for only the public build.

@eduardo-vp eduardo-vp force-pushed the backport-92375-to-release-8.0-staging branch from 895af02 to ee04040 Compare May 1, 2024 20:17
@eduardo-vp eduardo-vp force-pushed the backport-92375-to-release-8.0-staging branch from ee04040 to 5acba8c Compare May 1, 2024 20:34
@eduardo-vp eduardo-vp added the Servicing-consider Issue for next servicing release review label May 2, 2024
Copy link
Member

@jeffschwMSFT jeffschwMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved. we can take this as tell mode

cc @carlossanlop

@jeffschwMSFT jeffschwMSFT added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels May 2, 2024
@eduardo-vp eduardo-vp merged commit 37a6d07 into dotnet:release/8.0-staging May 2, 2024
186 of 190 checks passed
@eduardo-vp eduardo-vp deleted the backport-92375-to-release-8.0-staging branch May 29, 2024 20:36
@github-actions github-actions bot locked and limited conversation to collaborators Jun 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Infrastructure Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants