Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JIT: fix STRESS_BB_PROFILE issue #101925

Merged
merged 2 commits into from
May 7, 2024
Merged

JIT: fix STRESS_BB_PROFILE issue #101925

merged 2 commits into from
May 7, 2024

Conversation

AndyAyersMS
Copy link
Member

Incorporate "stress" profile counts even if we're not optimizing.

Fixes #101901.

@AndyAyersMS
JIT: fix STRESS_BB_PROFILE issue
2108306 
Incorporate "stress" profile counts even if we're not optimizing.

Fixes dotnet#101901.
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label May 6, 2024
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

@AndyAyersMS
Copy link
Member Author

I had this fix in #101739 but it got messed up by a bad merge at #101834.

@EgorBo PTAL
cc @dotnet/jit-contrib

@AndyAyersMS
Copy link
Member Author

/azp run runtime-coreclr jitstress

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@AndyAyersMS
Copy link
Member Author

Still more issues to sort out

Assert failure(PID 4748 [0x0000128c], Thread: 2868 [0x0b34]): Assertion failed '!"Inconsistent profile data"' in 'Chaos.A0:RecurseA0(int):this' during 'Morph - Inlining' (IL size 31; hash 0x7595e44c; FullOpts)

    File: D:\a\_work\1\s\src\coreclr\jit\fgprofile.cpp:4922
    Image: C:\h\w\A29B08A1\p\corerun.exe

@build-analysis build-analysis bot mentioned this pull request May 6, 2024
Closed
@AndyAyersMS
Copy link
Member Author

/azp run runtime-coreclr jitstress

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@AndyAyersMS
Copy link
Member Author

Need to make sure to scale inlinee counts only after we apply synthesis, otherwise the scale factor may be off.

This was referenced May 6, 2024
Closed
Closed
@AndyAyersMS
Copy link
Member Author

Issues are known. This is a stress mode only fix, so no diffs, as expected.

@AndyAyersMS AndyAyersMS merged commit 4e626e2 into dotnet:main May 7, 2024
121 of 125 checks passed
This was referenced May 7, 2024
Closed
Closed
michaelgsharp pushed a commit to michaelgsharp/runtime that referenced this pull request May 9, 2024
@AndyAyersMS @michaelgsharp
JIT: fix STRESS_BB_PROFILE issue (dotnet#101925)
4b15bab 
Incorporate "stress" profile counts even if we're not optimizing.
Scale after synthesis, not before.

Fixes dotnet#101901.
Ruihan-Yin pushed a commit to Ruihan-Yin/runtime that referenced this pull request May 30, 2024
@AndyAyersMS @Ruihan-Yin
JIT: fix STRESS_BB_PROFILE issue (dotnet#101925)
e5ad0df 
Incorporate "stress" profile counts even if we're not optimizing.
Scale after synthesis, not before.

Fixes dotnet#101901.
@github-actions github-actions bot locked and limited conversation to collaborators Jun 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@EgorBo EgorBo EgorBo approved these changes

Assignees

@AndyAyersMS AndyAyersMS

Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test failure GC\\API\\GCHandle\\AddrOfPinnedObject_neg\\AddrOfPinnedObject_neg.cmd
2 participants
@AndyAyersMS @EgorBo