Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark LoadFrom overload that always throws as obsolete #102292

Merged
merged 6 commits into from
May 17, 2024
Merged

Mark LoadFrom overload that always throws as obsolete #102292

merged 6 commits into from
May 17, 2024

Conversation

agocke
Copy link
Member

@agocke agocke commented May 15, 2024

Fixes #96410

@agocke agocke requested a review from jeffhandley as a code owner May 15, 2024 22:59
This was referenced May 16, 2024
Closed
Closed
@huoyaoyuan
Copy link
Member

Does this require change in reference source?

jkotas
jkotas requested changes May 16, 2024
View reviewed changes
Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this require change in reference source?

Good catch!

@jkotas jkotas mentioned this pull request May 17, 2024
Merged
@agocke agocke merged commit 12283e7 into dotnet:main May 17, 2024
144 of 146 checks passed
@agocke agocke deleted the mark-throw-obsolete branch May 17, 2024 18:53
@build-analysis build-analysis bot mentioned this pull request May 17, 2024
Open
Ruihan-Yin pushed a commit to Ruihan-Yin/runtime that referenced this pull request May 30, 2024
@agocke @Ruihan-Yin
Mark LoadFrom overload that always throws as obsolete (dotnet#102292)
f1d61f9 
Fixes dotnet#96410
@github-actions github-actions bot locked and limited conversation to collaborators Jun 17, 2024
@vcsjones
Copy link
Member

vcsjones commented Aug 8, 2024

@agocke doesn't this need a breaking change doc so the SYSLIB0056 gets documented? I don't see it in https://github.com/dotnet/docs/blob/main/docs/core/compatibility/core-libraries/9.0/obsolete-apis-with-custom-diagnostics.md

@jkotas jkotas added the breaking-change Issue or PR that represents a breaking API or functional change over a prerelease. label Aug 9, 2024
@dotnet-policy-service dotnet-policy-service bot added the needs-breaking-change-doc-created Breaking changes need an issue opened with https://github.com/dotnet/docs/issues/new?template=dotnet label Aug 9, 2024
@agocke
Copy link
Member Author

agocke commented Aug 9, 2024

Good catch -- I will add that before we ship

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jkotas jkotas jkotas approved these changes

@jeffhandley jeffhandley Awaiting requested review from jeffhandley jeffhandley is a code owner

@marek-safar marek-safar Awaiting requested review from marek-safar

@MichalStrehovsky MichalStrehovsky Awaiting requested review from MichalStrehovsky

Assignees

@agocke agocke

Labels
area-AssemblyLoader-coreclr breaking-change Issue or PR that represents a breaking API or functional change over a prerelease. needs-breaking-change-doc-created Breaking changes need an issue opened with https://github.com/dotnet/docs/issues/new?template=dotnet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Assembly.LoadFrom overload unconditionally throws NotSupportedException
5 participants
@agocke @huoyaoyuan @vcsjones @jkotas @MichalStrehovsky