Convert some more array FCalls to managed #102739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
needs-area-label
dotnet-policy-service
bot
added
the
community-contribution
huoyaoyuan
added
area-VM-coreclr
and removed
needs-area-label
|
Tagging subscribers to this area: @mangod9 |
huoyaoyuan
commented
May 28, 2024
...coreclr/System.Private.CoreLib/src/System/Runtime/CompilerServices/RuntimeHelpers.CoreCLR.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
May 28, 2024
...coreclr/System.Private.CoreLib/src/System/Runtime/CompilerServices/RuntimeHelpers.CoreCLR.cs
Outdated
Show resolved
Hide resolved
huoyaoyuan
commented
May 28, 2024
huoyaoyuan
commented
May 28, 2024
...coreclr/System.Private.CoreLib/src/System/Runtime/CompilerServices/RuntimeHelpers.CoreCLR.cs
Show resolved
Hide resolved
| { | ||
| switch (pMT->ComponentSize) | ||
| { | ||
| case 1: |
There was a problem hiding this comment.
Can we use sizeof(byte) and corresponding primitives for this switch statement?
There was a problem hiding this comment.
We are using such pattern in CoreLib. Sounds reasonable.
src/coreclr/System.Private.CoreLib/src/System/RuntimeHandles.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Private.CoreLib/src/System/Reflection/InvokeUtils.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Private.CoreLib/src/System/Reflection/InvokeUtils.cs
Show resolved
Hide resolved
jkotas
reviewed
Jun 24, 2024
...coreclr/System.Private.CoreLib/src/System/Runtime/CompilerServices/RuntimeHelpers.CoreCLR.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
Jun 24, 2024
...coreclr/System.Private.CoreLib/src/System/Runtime/CompilerServices/RuntimeHelpers.CoreCLR.cs
Outdated
Show resolved
Hide resolved
am11
reviewed
Jun 24, 2024
jkotas
reviewed
Jun 24, 2024
src/libraries/System.Private.CoreLib/src/System/Reflection/InvokeUtils.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
Jun 24, 2024
src/libraries/System.Private.CoreLib/src/System/Reflection/InvokeUtils.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Aaron Robinson <arobins@microsoft.com> Co-authored-by: Jan Kotas <jkotas@microsoft.com>
...coreclr/System.Private.CoreLib/src/System/Runtime/CompilerServices/RuntimeHelpers.CoreCLR.cs
Outdated
Show resolved
Hide resolved
huoyaoyuan
commented
Jun 26, 2024
...coreclr/System.Private.CoreLib/src/System/Runtime/CompilerServices/RuntimeHelpers.CoreCLR.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Aaron Robinson <arobins@microsoft.com>
AaronRobinsonMSFT
approved these changes
Jun 26, 2024
This was referenced Jun 26, 2024
Open
|
The timeout tests passed before a minor comment-only change |
|
Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge
IsSimpleCopyandCanAssignArrayTypeagain.Reused code for
PrimitiveWiden.Also include
InitializeArrayandGetSpanDataFrom. They are expanded in JIT so the managed definition is less performance critical.There would be no more FCalls in
Arraytype now.