Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misc Metrics Fixes #103791

Merged
merged 1 commit into from
Jun 21, 2024
Merged

Misc Metrics Fixes #103791

merged 1 commit into from
Jun 21, 2024

Conversation

tarekgh
Copy link
Member

@tarekgh tarekgh commented Jun 21, 2024

@tarekgh tarekgh added this to the 9.0.0 milestone Jun 21, 2024
@tarekgh tarekgh requested a review from noahfalk June 21, 2024 01:41
@tarekgh
Copy link
Member Author

tarekgh commented Jun 21, 2024

CC @KalleOlaviNiemitalo

This was referenced Jun 21, 2024
Open
Open
Closed
noahfalk
noahfalk approved these changes Jun 21, 2024
View reviewed changes
Copy link
Member

@noahfalk noahfalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tarekgh tarekgh merged commit 078d720 into dotnet:main Jun 21, 2024
79 of 83 checks passed
rzikm pushed a commit to rzikm/dotnet-runtime that referenced this pull request Jun 24, 2024
@tarekgh @rzikm
Misc Metrics Fixes (dotnet#103791)
4220bae
@github-actions github-actions bot locked and limited conversation to collaborators Jul 23, 2024
@tarekgh tarekgh deleted the MiscMetricsFixes branch August 6, 2024 20:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@noahfalk noahfalk noahfalk approved these changes

Assignees

@tarekgh tarekgh

Labels
area-System.Diagnostics.Metric
Projects
None yet
Milestone
9.0.0
Development

Successfully merging this pull request may close these issues.

DefaultMeterFactory does not pass MeterOptions future properties to Meter constructor
2 participants
@tarekgh @noahfalk